[Plugin: Prism Syntax Highlighter (detached)] Bug upstream in prism on safari 3.5

  • Resolved kriszani

    (@kriszani)


    12 years, 5 months ago

    I added a bug upstream earlier. In safari 3.5 and 3.6 if there is no line-height defined specifically in your css for a pre (or maybe the body tag) then one of the functions in the line-highlighter returns NaN (safari returns the text string normal, whereas firefox performs a calculation based on its defaults and returns a number) when it should return a number.

    the easiest fix is to add a line-height definition to the pre tag in the prism css files.

    this is just for info. not sure if you want to fix it. I think most people who use a reset css would have this covered. On the official prism site, the styles.css (which have nothing to do with prism have a definition so the examples on screen work but the downloaded files don’t).

    https://www.ads-software.com/extend/plugins/prism-detached/

Viewing 1 replies (of 1 total)
  • Plugin Author apfelbox

    (@apfelbox)

    Thank you for the heads-up, I already saw your ticket on GH (and just replied to it).

    I think, prism should provide a fallback line-height in this case (maybe depending on the font-size). But it should definitely be fixed in prism itself, since it also applies to all other installations of prism outside of this plugin.

    (I mark this as fixed, since it is “fixed” in the WP plugin, although it is still open in the prism plugin itself)

Viewing 1 replies (of 1 total)
  • The topic ‘[Plugin: Prism Syntax Highlighter (detached)] Bug upstream in prism on safari 3.5’ is closed to new replies.