Tp777 biz withdrawal.Makakuha ng libreng 700pho sa bawat deposito

Resolved MrVictor
(@mrvictor)

13 years, 5 months ago

Hi,

The Google Maps scripts load on every page right now! When I select one of my custom post types it should really only load when viewing my custom post type’s pages.

https://www.ads-software.com/extend/plugins/pronamic-google-maps/

Viewing 12 replies - 1 through 12 (of 12 total)

Thomas Jaggi
(@backflip)

13 years, 5 months ago

+1
Plugin Author Remco Tolsma
(@remcotolsma)

13 years, 5 months ago
Thanks for your advice, we adjusted some things in our plugin:
https://plugins.trac.www.ads-software.com/changeset/388776/pronamic-google-maps

On archive pages, and other special pages, the script will still always load. It’s not easy to tell if the script is not needed on these pages. Do you have an idea how to optimze this further?
```
if(is_singular()) {
	if(pronamic_google_maps_is_active()) {
		wp_enqueue_script('pronamic-google-maps-site');
	}
} else {
	wp_enqueue_script('pronamic-google-maps-site');
}
```
Thread Starter MrVictor
(@mrvictor)

13 years, 5 months ago

Okey.

Maybe you could give admins the opportunity to choose wich pages the script should load on? For me it would be enough to show it on single pages of a custom post type and on one page.

Thomas Jaggi
(@backflip)

13 years, 5 months ago

Couldn’t it be part of the map rendering?

Plugin Author Remco Tolsma
(@remcotolsma)

13 years, 4 months ago

I don’t think that is possible, scripts have to be enqueued before wp_head() is executed.

https://codex.www.ads-software.com/Function_Reference/wp_register_script

Thomas Jaggi
(@backflip)

13 years, 4 months ago

Scribu presents some nice solutions: https://scribu.net/wordpress/optimal-script-loading.html

Plugin Author Remco Tolsma
(@remcotolsma)

13 years, 4 months ago

Thanks for the link, I made some adjustments and this could work. However the Google Maps API documentation says that the scripts should be place in the <head> section.

https://code.google.com/intl/nl/apis/maps/documentation/javascript/tutorial.html#Loading_the_Maps_API

With the solution from Scribu the scripts are placed in the footer (before the </body> tag). Do you have any idea what kind of effect this will have?

The solution is working in Firefox 3.6.16, Internet Explorer 9 and Google Chrome…

Some more related links:
– https://beerpla.net/2010/01/15/follow-up-to-loading-css-and-js-conditionally/
– https://beerpla.net/2010/01/13/wordpress-plugin-development-how-to-include-css-and-javascript-conditionally-and-only-when-needed-by-the-posts/

Thomas Jaggi
(@backflip)

13 years, 4 months ago

I guess Google just assumes that a map should load as early as possible. But as far as I know it works just fine if you include the scripts at the end of your markup.

Plugin Author Remco Tolsma
(@remcotolsma)

13 years, 4 months ago

Ok, thanks. We used the solution from Scribu in version 1.8:
https://www.ads-software.com/extend/plugins/pronamic-google-maps/

Thomas Jaggi
(@backflip)

13 years, 4 months ago

Great!

pintofmilk
(@pintofmilk)

12 years, 8 months ago

I am running wp_enqueue_script(‘pronamic-google-maps-site’); in functions-user.php when the page loads but the script is not being inserted into the HTML code.

Other scripts are being properly enqueued from the same code block – do I need to add something else?
Plugin Author Remco Tolsma
(@remcotolsma)

12 years, 8 months ago
Do you enqueue the script within the ‘wp_enqueue_scripts’ routine?
```
function prefix_enqueue_scripts() {
	wp_enqueue_script('pronamic-google-maps-site');
}

add_action('wp_enqueue_scripts', 'prefix_enqueue_scripts');
```
https://codex.www.ads-software.com/Function_Reference/wp_enqueue_script

Viewing 12 replies - 1 through 12 (of 12 total)

The topic ‘[Plugin: Pronamic Google Maps] Load script only on pages (post types) with maps?’ is closed to new replies.