Plugin registers new user despite register being disabled

That’s right, it does do that. I can agree that it should fail in that case, but I wasn’t sure how registration should’ve worked in that case, so here we are.

I guess we should register new users with the current method, just like we do now, but only if the setting is not disabled. Once the account-to-address linker feature is in, it starts making sense.

Might be good to have a registration flow where they can pick a username?

Probably.

But with email confirmations, etc., not sure how that would work. Just display a registration box with nickname and “register with metamask”? But that will ignore all other fields, if present. Probably there’s a dozen registration form plugins; maybe difficult to play nice with all of them.

Using the account linker makes more sense if you want usernames, I think. Perhaps there needs to be a way of disabling registrations through EthPress, while keeping regular registrations available.

For now it could be login-only, meaning you can’t register through Address and can only link the address once you’ve registered with email. Almost like a 2FA or login-with-thumbprint.

The current “log in to register and login” flow has its place, I think, but it will become dependent on the “users can register” flag in WP. If that isn’t active, then it will work only as you describe.

That way seems intuitive, I think.

I suppose it depends on the intent of the webmaster. There is a place for address-as-username and for address-as-a-field. This is a hard problem I think, because it is foundational – username cannot be changed after registration (I think). Hard to present the option coherently as well.

Hey there,

I just pushed a little patch to the add-linker branch, which will disable registration if you’ve disabled it from settings. Give it a spin, and give feedback. Thanks!

Seems to function as expected!

The profile “add address” functionality works great as well. Feedback on that:
– remove the MetaMask button on successful linking.
– show the current linked address above the button to show that the account is linked; otherwise it seems like the action did not succeed.

Alright, showing the address sounds like a good idea.

Remove the button, or close the modal? I think that the possibility of linking multiple addresses in a row, exists.

Either remove the button or close the modal and show the address as added.
Multiple addresses should probably be added when people ask for it; likely a minority feature.

Multiple addresses can be linked to an account. That was the easy way of implementing this.

Will have to flash a success message and close the modal

Just updated the add-linker branch again.

I chose not to close the modal for now, there’s no good indicator built for that yet, and randomly closing it after 2 seconds isn’t an improvement based on my testing.

I tried changing some text around to make it more obvious that you can link many wallets, so maybe it is more clear that the dialog has to be closed by the user.

It shows the added address in a success message now.

It turns out that the recently released MetaMask version 8.0 makes the “multiple wallets per account” system less useful, since they now track connected wallets on a per-site basis, but that’s alright. It can still be used for linking your WalletConnect wallets, at least.

In case anyone else is interested in trying, but does not wish to go through git & composer stuff, version 0.7.1 is now available as the “development version” on https://www.ads-software.com/plugins/ethpress/advanced/ . You can install it from wp admin “add new” and upload the zip and so forth.

I will be making it the default tag after the next WordPress release happens, which is soon, once I confirm that it works with the new version.

Just pushed 0.7.1, which fixes this.