• Resolved blam4c

    (@blam4c)


    There’s a little problem with this new implementation:

    When this plugin is loaded it creates an instance of the Sociable class at once. While doing so it fills the “sites” property with the known sites and runs the “sociable_known_sites” filter.

    If however I have another plugin that implements a filter for “sociable_known_sites” which is loaded AFTER the sociable plugin, my filter is never executed, because the Sociable object is already created.

    You should try to fill and filter the sites array as late as possible, not right at the start when the plugin is loaded.

    A second downside of doing this is that the code is executed on every site, even if the array is never needed (e.g. on most pages of the admin area, …)

    https://www.ads-software.com/extend/plugins/sociable-30/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author tompokress

    (@tompokress)

    Hi,

    That makes sense, I’ll apply the filter later – I’ll try to patch the code today. Did you have a specific plugin in mind that actually uses the filter or are you writing something new?

    Thread Starter blam4c

    (@blam4c)

    I’m using my own – which is not, yet, released to the public.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘[Plugin: Sociable for WordPress 3.0] Add bookmarking services’ is closed to new replies.