[Plugin: Subscribe To Comments Reloaded] CSS Class Option Missing, Several Debug Errors

  • Resolved sahaskatta

    (@sahaskatta)


    13 years, 4 months ago

    I just installed the latest 2.0 version on WP 3.2.1 with debug enabled on a dev server. I’m getting several of warnings across the settings pages. Mostly undefined variables which are easy fixes. It also prints out a warning where the comment check-box should be on the front end too.

    I also noticed you removed the option for adding a CSS Class in the options panel. Just curious why you made that choice. I’m sure there’s a good reason, but I might have been “that one guy” using that feature.

    I have the styling in my CSS file and in-line styling is generally considered bad for page performance — every little bit adds up.

    Anyways, great upgrade! Sorry for trouble.

    https://www.ads-software.com/extend/plugins/subscribe-to-comments-reloaded/

Viewing 3 replies - 1 through 3 (of 3 total)

  • Hi there,

    you’re right about the warnings, I was so excited to release this long-awaited version that I didn’t want to make its users wait any longer ?? I will polish the source code in version 2.1, along with some other new features users have requested in the past few months.

    As for that CSS class option, that was actually redundant, since you can already define the “wrapping” HTML code in the corresponding field. That HTML code is the place where to put your class definition. Why use a separate option for that? ?? Does it make sense to you? No inline style needed, but not everybody knows how to edit a CSS file, so having a field for inline code is handy to many users, according to what I’m told.

    A vote for ‘works’ would be really appreciated!

    Camu

    Thread Starter sahaskatta

    (@sahaskatta)

    Camu,
    Thanks for the speedy response.

    You are absolutely right about the CSS thing. No clue why adding the class in the HTML wrapping didn’t cross my mind.

    As I expected, you knew what you were doing! ??

    As for the warning, even WordPress core developers advise against leaving WP_DEBUG active in production environments ?? Of course I’ll get rid of those warning anyway…

    Camu

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘[Plugin: Subscribe To Comments Reloaded] CSS Class Option Missing, Several Debug Errors’ is closed to new replies.