Plugin upscales images that are too small

Hi there,
the plugin is designed to make upscale possible. If the user do not want upscale it could simple leave the image as it is.

But you are right the metadata should be updated if an upscale happens.

I had a quick look into the saving process. The attachement_metadata should have been updated. I had all the code in there.
https://github.com/vollyimnetz/crop-thumbnails/blob/master/functions/save.php
Line 121-132 and Line 142

You say the attachements-meta-data did not update?

Hi Volkmar,

thanks for you quick reply! I think you misunderstood, there’s no problem with the metadata, everything works correctly.

Here’s an example. I have registered additional image sizes, onbe of them is 900×450. Then I uploaded an image that’s only 520×347 and wanted to adjust the cropping area. Although the original image is too small, the plugin generates a file with dimensions 900×450. Here’s my wp_get_attachment_metadata() Array:

Array
(
    [width] => 520
    [height] => 347
    [file] => 2016/03/01/myfile.jpg
    [sizes] => Array
        (
            [thumbnail] => Array
                (
                    [file] => myfile-400x267.jpg
                    [width] => 400
                    [height] => 267
                    [mime-type] => image/jpeg
                )

            [feature_large] => Array
                (
                    [file] => myfile-900x450.jpg
                    [width] => 900
                    [height] => 450
                    [crop] => 1
                )

        )

    [image_meta] => Array
        (...)
)

You see: the plugin creates an image which is larger than the original one, does all the metadata updating correctly. But: this puts low-quality images into the system since they’re larger than the uploaded original. You get what I mean?

Maybe my assumption is wrong that nobody would upscale an image beyond its original size (since this results in poor image quality), but I might be wrong.

In my code I can circumvent this, but if this really is a bug (and not a feature;) this might be worth some consideration in a future update. I’d appreciate that!

Thanks
Thomas

For me, it makes perfect sense to give users the possibility to fix a image sizes, even if it results in images with less qualtity. Think about: cropped image sizes are important for web-developer like me – it makes sure a image had a certain proportion and size.

I have a lot of clients which are not as fit with desktop image-manipulation as me (or not care about). With my plugin i create an easy tool to stil get the right dimensions for an image (so there theme dont look so messy).

ok, i get your point. in this case this may indeed be desirable. maybe you want to consider an optional switch for people who’d like to prevent upscaling in a future update. that’d be really cool and make the plugin even more versatile. for now: thanks for the tool and your quick support!