• Resolved Chasal

    (@chasal)


    Hi all,

    There is a wonderful mistake in the latest version of sunrise.php.

    It can be found between line 37 and 38.

    This \n breaks all the medias.

    I lost a loooooot of time to find out the problem.

    Please simply do as every normal php dev would do with INCLUDED php files : don’t use the closing ‘?>’ tag, especially if you plan to add empty lines in the end of the file.

    Empty lines that are then written by ms-files.php right before the media content and make it break.

    Thanks a lot.

    https://www.ads-software.com/extend/plugins/wordpress-mu-domain-mapping/

Viewing 11 replies - 1 through 11 (of 11 total)
  • Thread Starter Chasal

    (@chasal)

    Plugin Author Ron Rennick

    (@wpmuguru)

    First – the zips are created automatically by www.ads-software.com. A plugin author has no access to the zip generation process.

    Second – To check your claim I downloaded a fresh copy of https://downloads.www.ads-software.com/plugin/wordpress-mu-domain-mapping.0.5.4.2.zip and there isn’t a blank line at the end of sunrise.php. There must have been something on your computer that caused it.

    Thread Starter Chasal

    (@chasal)

    Hi,

    Could you download the copy i uploaded on my server (i wrote the link). I confirm that I checked more than twice. Opening it with sublime text on a fresh install of Windows 7 shown me this \n

    Anyway, I discovered it before on my own server by doing a $ nano ./sunrise.php

    Also, I just downloaded from the link you gave and got the same mistake on Sublime Text Mac and TextWrangler mac. Do you really want more screenshots ? see https://twitpic.com/an4tbm , see https://twitpic.com/an4txi

    I am at my office right now and I am using the company’s computer and internet connection. So it is not specific to my computer or even my home internet connection.

    You can solve this problem just by removing the ‘?>’

    Thanks,
    Thanks a lot.

    Thread Starter Chasal

    (@chasal)

    I can test on some others computers, I am sure I’ll get the same error, flawlessly.

    Please give me the MD5 hash of the zip version you downloaded to your computer.

    Thread Starter Chasal

    (@chasal)

    Here is mine :

    ~/Downloads$ md5 ./wordpress-mu-domain-mapping.0.5.4.2.zip
    MD5 (./wordpress-mu-domain-mapping.0.5.4.2.zip) = 5258347942eac8b835772b439b6999cc
    ~/Downloads$ date
    Ven 24 ao? 2012 14:36:32 CEST

    Here is what nano sees in sunrise.php i just downloaded from your link :
    https://twitpic.com/an4zd2

    Thread Starter Chasal

    (@chasal)

    Hi,

    Sorry for having been rude. But I think you can understand the first frustration.

    Anyway, I am wondering wether the problem comes from the zip generation process or anything else.

    It’s strange.

    Take care.

    Plugin Author Ron Rennick

    (@wpmuguru)

    I don’t have command line md5 installed.

    However, PHP allows a newline after the closing ?> without inserting a newline into the output. It would only start output if a space or other character was added after the newline.

    Thread Starter Chasal

    (@chasal)

    So, the archive is bugged. I am right until you prove I am wrong on this one.

    Please, for the sake of other users who will stuck on this one, please do (please !) remove this ending ‘?>’ until you find a way to make sure wordpress zip generation process doesn’t add this empty line.

    I beg you.

    Thanks a lot for your patience with me.

    Here is my output:

    5258347942eac8b835772b439b6999cc wordpress-mu-domain-mapping.0.5.4.2.zip

    It doesn’t have an extra line for me. I checked in gedit in Gnome. Also, I haven’t heard of anyone else having this problem. It seems isolated to your environment.

    So, the archive is bugged. I am right until you prove I am wrong on this one.

    It appears that English isn’t your first language, so it may not occur to you that sentence sounds abrasive. It is also factually inaccurate, as you are the only one having this issue. So, deep breath, and try re-downloading the archive (or install it from the admin dashboard and network activate it).

    Thread Starter Chasal

    (@chasal)

    Hi,

    You are right, English isn’t my first language.

    I suppose you believe me when i say that I downloaded it to both a windows 7 and a Mac Os X Lion environment and did not modify the file or anything.

    I personally own one Windwos 7 pc, one Mac Os X and I also used another mac os x that belongs to my company.

    I suppose you also believe me when i say that, at the begining, the version i got on my server was downloaded and unzip by my wordpress install. My server runs a customized version of BSD. The first time I noticed the problem was after debuging using the shell. I got this on nano / vim.

    What can we do ? Do you really want a video record showing how I do to get the same problem ? (Just download that archive, unzip, open sunrise.php with any text editor).

    I am ready to follow your suggestions.

    What can we do ? Do you really want a video record showing how I do to get the same problem ? (Just download that archive, unzip, open sunrise.php with any text editor).

    That sounds like a good idea. Please link to a video, showing the steps you are taking.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘[Plugin: WordPress MU Domain Mapping] BUG THAT Drove me nuts – everythin broken’ is closed to new replies.