pmpro_visit Cookie for non-logged in users

  • Resolved MegaZ

    (@megaz)


    5 years, 1 month ago

    Your plugin used to only set the pmpro_visit cookie for logged in users before. The code in login.php file under pmpro_report_track_values previously used to do this:

    if(!is_user_logged_in()
    return false;

    This made caching plugins work perfectly fine, since the cookie was not being set. Since the last update, this code has been removed and now the plugin is setting the pmpro_visit cookie for every load, which breaks all caching plugins.

    Please revert to previous function to only initiate the cookie when a user is logged in.

    Thank you.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Andrew Lima

    (@andrewza)

    Hi @megaz

    Thank you for using Paid Memberships Pro and for bringing this to our attention.

    I see you have opened an issue on Github for this. Our development team will be looking into this as soon as they can.

    Thread Starter MegaZ

    (@megaz)

    I reported this problem a long time ago now and you guys still have not fixed it!

    Look, all you have to do is change the following file:
    adminpages -> reports -> login.php

    Insert on line 401:
    if(!is_user_logged_in()) return false;

    Once this is done, the cookie is not going to set and caching is going to work. Is this so hard to fix? I do not want to be patching your plugin every single time you guys release an update.

    Please fix this.

    Thread Starter MegaZ

    (@megaz)

    Four months, still no traction. Is it really this hard to add a single line of code to fix this problem? Plugins like this are the reason why so many WordPress sites on the Internet underperform. People have no clue that one of their plugins is causing every page to generate a cookie, avoiding caching completely.

    I am shocked that I have to patch every single one of your releases. Time to move on to something else…

    Plugin Author Andrew Lima

    (@andrewza)

    Hi @megaz

    Thank you for your feedback, I’m sorry about this your issue got lost along the way.

    Here is a code snippet that you can add to your site so you don’t have to patch it on each update that Paid Memberships Pro releases – https://gist.github.com/ideadude/27912cd472e1216ba73420386ddae2ce

    This is a temporary solution until we handle this inside the core version of Paid Memberships Pro.

    I hope this helps.

    Thread Starter MegaZ

    (@megaz)

    Andrew, how many more months until you fix this basic problem that is affecting EVERY single person who downloads and uses your plugin?

    In all seriousness, I find it baffling that your team cannot add one line of code. Do you realize that every customer of yours cannot cache ANY page of WordPress because of your plugin?

    Plugin Author Jason Coleman

    (@strangerstudios)

    > I find it baffling that your team cannot add one line of code.

    That function tracks member visits and the total number of visits to the website, including logged out users. We would like to track total visits by default, so we are not going to update that code.

    You can use the gist provided by Andrew earlier on your site to change the behavior for your site in particular.

    Thread Starter MegaZ

    (@megaz)

    Jason, do you realize that your plugin causes caching not to work on every page of a website, simply because you choose to count total number of visits to the website?

    I look at this as a very serious flaw – you are essentially helping make the Internet slower. Are your customers aware of this? Any proxy cache server, including Cloudflare, will not cache ANY pages of a website that uses your plugin. You guys need to take this into account and move the tracking feature as an option, which is NOT enabled by default.

    I know how to fix your code and I can easily do this. But what about everyone else who is not technical enough to implement these fixes?

    Jason, that’s what google analytics is for, breaking cache for every site just to put a total visits number on the dashboard is a horrible idea… If you feel you absolutely must do it, add a javascript file to do it in the background

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘pmpro_visit Cookie for non-logged in users’ is closed to new replies.