popup maker is not compatible with php7

  • Resolved ivanomino

    (@ivanomino)


    8 years, 2 months ago

    I am sorry,
    this is the second post that i wrote here, about your plugin that is not compatible with php7.

    This is what hosting support said about:
    Hello,

    Thank you for the update.

    The developer of the plugin is I guess referring to the following not found error messages in the strace logs that my colleague provided you with:

    Code:
    23616 access(“/home/creazi04/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated/v0.php”, F_OK) = -1 ENOENT (No such file or directory)
    23616 access(“/home/creazi04/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated/v1.php”, F_OK) = -1 ENOENT (No such file or directory)
    23616 access(“/home/creazi04/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated/v2.php”, F_OK) = -1 ENOENT (No such file or directory)
    23616 access(“/home/creazi04/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated/v3.php”, F_OK) = -1

    This is not a server side problem, since the listed files actually do not exist on your account with us:

    Code:
    [email protected] [~/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated]# ll
    total 60
    drwxr-xr-x 2 creazi04 creazi04 4096 Aug 17 23:27 ./
    drwxr-xr-x 8 creazi04 creazi04 4096 Aug 17 23:27 ../
    -rw-r–r– 1 creazi04 creazi04 45026 Aug 17 23:27 v4.php
    -rw-r–r– 1 creazi04 creazi04 5769 Aug 17 23:27 v6.php
    [email protected] [~/public_html/wpideainmedia.com/contents/plugins/popup-maker/includes/deprecated]#

    Still, our investigation is showing that the specified plugin is not compatible with PHP 7.x. Please confirm with the developer of the plugin if their plugin is fully compatible with PHP 7.x. If it is not, you should consider removing it when you wish to use PHP 7.x.

    Based on the following thread:

    https://www.ads-software.com/support/topic/compatible-with-php-7-12

    the plugin has been tested up to PHP 5.6.

    As we have explained, the issue is not server side related one, but it is caused by the fact that your plugin can not work properly with PHP 7.x.

    https://www.ads-software.com/plugins/popup-maker/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @ivanomino – Unfortunately they are partially correct that the files listed there do not exist, but wrong again in that it doesn’t work on PHP 7. I set up this test just for you to confirm yourself: https://examples.wppopupmaker.com/ – Simply added a phpinfo shortcode to the popup. As you can see 100% working fine on PHP 7.0.1.

    As I said all of our own sites run on PHP 7+

    Now as to the files it is trying to load. It shouldn’t be. We use file_exists() to check for those files prior to loading them: https://github.com/PopupMaker/Popup-Maker/blob/c8bb759c9527497ada68d902efeba3476ff83bfa/includes/pum-deprecated.php#L23

    Based on this q&a those don’t matter and appear simply because we checked for the file existing. We do it properly and you can safely ignore those messages based on this link: https://stackoverflow.com/questions/25197019/no-such-file-or-directory-after-running-strace-in-apache-server

    The ticket your host linked is over 9 months old. On top of that he didn’t state there was an incompatibility, just a question of whether it was or wasn’t. Sounds like your host didn’t actually read it. In fact no issues were ever found, hence the reason no response was ever made.

    Feel free to invite your host to dispute these facts, but just to further prove my point I queried our tracking data.

    Showing rows 0 - 99 (244 total, Query took 0.0111 seconds.) [php_version: 7.0.9-1~DOTDEB+8.1... - 7.0.7-1~DOTDEB+8.1...]
SELECT * FROM 'wp_tracking_v2' WHERE 'php_version' LIKE '7%' ORDER BY 'php_version' DESC

    Total rows 5116

    PHP 7 Usage = 244/5116 = ~5% of all tracked installs using Popup Maker.

    Since only ~10% have opted in to tracking we can multiply that out to be ~2440 installs using Popup Maker on PHP 7+

    Sorry its not the answer your after, but there is nothing we can do better to clear that up. We do it 100% correctly by using file_exists() before trying to load the file. The info you provided isn’t actually an error, just a debug notice indicating that a file was checked for.

    So back to the root cause, if your getting 500 errors it isn’t generated by those messages.

    I am getting a “Plugin is not compatible with PHP 7.0.” error from SiteGround:

    FILE: …/public_html/wp-content/plugins/popup-maker/includes/libs/browser.php
    ———————————————————————————————-
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ———————————————————————————————-
    225 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
    —————————————————————————————–

    I just ran the check today and getting the following errors:

    Name: Popup Maker

FILE: /wp-content/plugins/popup-maker/includes/class-pum-activator.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 51 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/libs/browser.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 225 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
----------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/tools/tools-page.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 322 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
---------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/upgrades/class-pum-admin-upgrade-routine-6.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 55 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-----------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/upgrades/class-pum-admin-upgrade-routine-2.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 37 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-----------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/upgrades/class-pum-admin-upgrade-routine-5.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 43 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-----------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/upgrades/class-pum-admin-upgrade-routine-3.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 48 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-----------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/admin/upgrades/class-pum-admin-upgrade-routine-4.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 48 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-----------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/popup-maker/includes/pum-sdk/freemius/includes/fs-essential-functions.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 165 | WARNING | Function name "__fs" is discouraged; PHP has reserved all method names with a double underscore prefix for future use
---------------------------------------------------------------------------------------------------------------------------------------

Name: Popup Maker - Advanced Targeting Conditions

FILE: /wp-content/plugins/popup-maker-advanced-targeting-conditions/classes/Migration.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 60 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4.
-------------------------------------------------------------------------------------------------------------------
    Plugin Author Daniel Iser

    (@danieliser)

    @subeaseadmin – Pretty much all false positives. The safe_mode test will never cause an error. Without it the plugin could cause issues though on PHP 5.2.4 which is still supported by WP core and thus by us too.

    To clarify for others we call ini_get( ‘safe_mode’ ) which will just return false on PHP 7 and continue on, if on PHP 5.2.4 and safe mode is enabled the next line would cause a fatal error, thus we cannot remove it until WP Core removes support for that version.

    I can make a small change to the includes/libs/browser.php that will remove that one but again, won’t actually cause any errors.

    As you can see from my link early on the plugin 100% works fine without errors in your logs on PHP 7+.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘popup maker is not compatible with php7’ is closed to new replies.

Tags