Popup Maker not working when Tablepress is active

  • Resolved kjm44

    (@kjm44)


    8 years, 4 months ago

    Hello. I am using Tablepress on my site and it has been working perfectly. Today I installed Popup Maker and it will not work (can’t get popup to open). When I checked the Javascript console in Firebug I get this error message:
    Type error: i is undefined. createElement(h.sCellType);i._DT_CellIndex={row:b,column:l};g.push(i);if(!c||h.mRender||h.mData!==l)

    It says the problem is in jquery.datatables.min.js?ver=1.7 which is a file loaded by the Tablepress plugin.

    If I deactivate Tablepress then Popup Maker works. I don’t even have a table on the page that I have the popup link on. See https://collaborateinnovate.com.au/contact/

    I’d really like both to work, I certainly can’t live without tablepress.

    Any help much appreciated.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Tobias B?thge

    (@tobiasbg)

    Hi,

    thanks for your question, and sorry for the trouble.

    The page from your link does contain the table with the ID 10 somehow, it seems to be in the popup content?
    The problem is that that table is using merged cells (using the #colspan# keyword) and the DataTables JS library at the same time. This is not possible as DataTables does not support tables with merged cells. You will have to decide: Either remove all #colspan# from table 10 or turn off the “Use DataTables” checkbox on its “Edit” screen.

    Regards,
    Tobias

    @tobiasbg – Hey Guys, Dev of Popup Maker here. Just wondering if this is something that happens to many people, if so maybe a good idea to put some type of sanity check in there to prevent those two settings from enabling something together. Just my 2 cents. Take care.

    Plugin Author Tobias B?thge

    (@tobiasbg)

    Hi,

    it does happen once in a while but it’s only an edge case and only related to TablePress. There is a check in place that should prevent this when using the regular user interface, but there’s no protection when someone enters the keyword manually. Maybe should extend the check to that somehow…
    Thanks for the input!

    Best wishes,
    Tobias

    @tobiasbg – Not a problem, as I said my 2 cents, you obviously know your code better than me so it would still be your call.

    That said over the last few major cycles with Popup Maker a big focus has been on redeveloping all of the settings & interfaces in a way that eliminates our support tickets. IE if a specific issue causes a lot of tickets, we redevelop that feature so that it works the way users are expecting it to.

    For instance in our initial release popups didn’t load anywhere without enabling at least one condition, but we would get 40% of our tickets asking why its not working, first question did you add a condition usually fixed it.

    So in v1.4 we changed it, so if you don’t add any conditions it assumes you want it on everywhere all the time. No more condition based support tickets.

    We have cut our support in half this way over the last 9 months. Looking to do it again soon ;).

    Plugin Author Tobias B?thge

    (@tobiasbg)

    Hi,

    that’s definitely a good strategy! I should probably start doing some statistics on the most frequent issues in tickets as well ??

    Best wishes,
    Tobias

    @tobiasbg – +1

    Plugin Author Tobias B?thge

    (@tobiasbg)

    Hi,

    great, thanks again!

    Best wishes,
    Tobias

    Thread Starter kjm44

    (@kjm44)

    Hello,

    Sorry I didn’t see this earlier, for some reason your answers didn’t come through to me.

    Yes, I had a table in the popup content and yes, the table was using the DataTables JS library. However, that was a mistake – I had copied the table across from another site and forgotten to turn the Datatables feature off – I actually don’t need it in this table.

    So, I’ve now turned it off and the popup is working – I’m delighted.

    thanks for both sets of replies and thanks very much for your help!

    Plugin Author Tobias B?thge

    (@tobiasbg)

    Hi,

    great to hear that! Thanks for the update on this!

    Best wishes,
    Tobias

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Popup Maker not working when Tablepress is active’ is closed to new replies.