Popups on Draft go to Posts

Hi @neilgee

Do you have a screenshot, or even better a login to the site so I can check it out?

You can send the details here: https://wpdevelopers.co.uk/contact/

Thanks!

Doug

Hi Doug – sent you the details to the email address.

Cheers
Neil

Hi Neil

Thanks – I’ve managed to log in.

I’ve just tested creating one, saving as Draft, but it hasn’t appeared in ‘Posts’.

Could this be related to the ‘post type switcher’ plugin?

https://www.dropbox.com/s/paibfq54vtotvtq/Screenshot%202018-02-19%2014.24.02.png?dl=0

https://www.dropbox.com/s/4ng1p8vk8mddy1k/Screenshot%202018-02-19%2014.25.06.png?dl=0

That is the only way I could imagine a post jumping from one type to another if this was changed.

With that ‘hunch’, I’d imagine the following happened:

– Popup was published in the usual way (with post type ‘wpd_bb_popup’)
– Popup was allocated to a section on the site using the Popup Manager
– Popup was switched to post type ‘post’ with Post Type Switcher
– Because the popup still existed in the database, the popup ID was still found by Beaver Popups and still tried to display it

Also, because the popup post type is hidden, it is not possible to use the same post type switcher plugin to switch back…

So if this is correct, I need to

1) Figure out a way to destroy old-popups
2) Disable post type switcher inside Beaver Popups; or
2) Do a check for the post type

I was trying to export your database using a plugin you have installed so I could try and solve #1 manually, but it’s giving me a 500 error. Are you able to send an export?

Doug

Hi Neil

To follow up:

I’ve found another situation where this could happen, but in a slightly more hidden fashion.

On the Popups ‘listing’ page, where you can ‘quick edit’ posts, I’ve noticed that when you quick-edit a popup, the post type switcher plugin automatically switches the popup to a different post type… and there’s no way to avoid it!

So if at any point you used quick-edit, this would have switched the post type!

This presents a slightly trickier problem for me, as even if I hide the post type switcher dropdown field from this page, it will still set the new post type if you click update.

Here’s a GIF explaining what I mean: https://cl.ly/35260N0e2G2G (notice the fact ‘post’ is selected when I click ‘quick edit’)

I think first, I will get in touch with the author of Post Type Switcher and ask if there could be a way to exclude certain post types from displaying this dropdown field at all as this could affect a lot of other plugins too, I’d imagine (otherwise I’ll do it another way…)

Regards
Doug

Hi @neilgee

OK, I’ve logged a ticket with Post Type Switcher: https://github.com/JJJ/post-type-switcher/issues/10

Let’s hope this is the issue now (99.9% sure it is! ??

In the next version of Beaver Popups, I’ll try and remove the select field from the ‘quick edit’ screen at least until Post Type Switcher is updated.

Doug

Hi Doug,

You hit the nail on the head there – that’s exactly what I did – was to use the Quick Edit screen and as you discovered thats when it changed the post type to post.

I know that Post Type Switcher got updated recently so the developer should be actively looking at issues.

Normallu I may use the switcher in development when converting a bunch of CPTs then disable it – but obviously a lot of sites also use it and would leave it enabled – it has an active install base of over 70,000.

Thanks for looking into it and working out the problem.

Regards
Neil

• This reply was modified 6 years, 9 months ago by neilgee.

Hey @neilgee

I’m going to close this one – I’ve tried to hide post type switcher in a recent update, but fundamentally this is a Post Type Switcher issue (and unfortunately no answer from them after I logged my issue with the developer 3 months ago – I’m sure they’re busy, although I can see this causing other problems for other plugins other than Beaver Popups).

I’m sure they’ll fix in due course.

Doug