Possible conflict with theme

  • Resolved stevkats

    (@stevkats)


    3 years, 4 months ago

    Hello,

    I’ve recently started using site reviews, which is fantastic by the way!

    There is a weird conflict that I’ve noticed though which relates I beleive to the theme I’m using. The theme is Micro Jobs by PremiumPress.

    Since installing Site Reviews, whenever I click on the theme’s settings (https://prnt.sc/1z1dlh3), instead of seeing the theme’s settings, I get “redirected” to the Site Reviews settings but they are just blank content tabs. Here is a screen: https://prnt.sc/1z1daj5

    As you can see the actual url is different from that of Site Reviews settings, which would be like: example.com/wp-admin/edit.php?post_type=site-review&page=settings (which works ok – I can see the plugin’s settings).

    If I deactivate Site Reviews then I can access my theme’s settings. I see no JS errors on the console. Would there be a way to identify and fix this somehow?

    Thanks.

    Kind Regards,
    Stavros

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Gemini Labs

    (@geminilabs)

    Yes, this is a bug. I’ll try to have it fixed in the upcoming v5.17.0

    Plugin Author Gemini Labs

    (@geminilabs)

    This might even be a WordPress bug.

    Site Reviews registers the submenu pages like this:

    add_submenu_page('edit.php?post_type=site-review', ...)

    This is how you are supposed to do it for custom post types. For some reason, the pages are not being restricted to edit.php.

    Regardless, I’ll add a check for this in v5.17.0

    Plugin Author Gemini Labs

    (@geminilabs)

    If you can’t wait for v5.17.0 and want to patch it yourself, please see: https://github.com/pryley/site-reviews/blob/8ef8656318fa41999f19ff64d6cb138cbf103f8a/plugin/Controllers/MenuController.php#L50-L53

    Plugin Author Gemini Labs

    (@geminilabs)

    Actually don’t use that fix, it’s not a correct solution.

    Plugin Author Gemini Labs

    (@geminilabs)

    Yes this is a WordPress bug where a submenu page of a custom post type can collide with a regular submenu page if the slugs are the same.

    For example, here is the same bug with the Advanced Custom Fields plugin:

    https://example.com/wp-admin/edit.php?post_type=acf-field-group&page=acf-tools
    https://example.com/wp-admin/admin.php?page=acf-tools

    Both of those links will load the same page, but the second one will be broken. And if another plugin registers a submenu admin page with the same slug where the parent page slug is not for a custom post type, (i.e. ?page=acf-tools), then the ACF page will override it if the ACF plugin is loaded first.

    All this to say, I’m probably going to have prefix all of the page slugs to fix these potential collisions.

    Thread Starter stevkats

    (@stevkats)

    Hello again,

    Thank you for your immediate and helpful replies. I actually used the hotfix you first suggested and it got fixed. Coincidentally, a new WP version just rolled out so that was automatically applied. I also updated your plugin today (since you rolled out a couple of new updates).

    Also I was planning to use ACF PRO so I installed that today (after all above updates) and no issues of the same nature occurred again (as mentioned in your acf example). I believe you may have been correct that it was a WP bug as another plugin I used before was also exhibiting the same behavior (https://www.ads-software.com/plugins/notification/) when trying to access my theme’s settings.

    Ah well, seems like issues are resolved now so all good. Thanks again for your awesome support!

    Best Regards,
    Stavros

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Possible conflict with theme’ is closed to new replies.