Possible Typo in Code

  • Resolved vincentjflorio

    (@vincentjflorio)


    9 years, 8 months ago

    About 90% of the way down easy-facebook-likebox.php there is this line:

    $responsive = ( $responsive == 1 ) ? 'data-adapt-container-widthtrue' : 'data-adapt-container-width=false';

    I believe the first part, it being true, should include the ‘=’ sign as well, to be

    $responsive = ( $responsive == 1 ) ? 'data-adapt-container-width=true' : 'data-adapt-container-width=false';

    because the front-end output doesn’t recognize it as a valid attribute otherwise.

    https://www.ads-software.com/plugins/easy-facebook-likebox/

Viewing 3 replies - 1 through 3 (of 3 total)

  • I think you’re right! How did you even discover this? Did you run into some sort of runtime error?

    Thread Starter vincentjflorio

    (@vincentjflorio)

    I didn’t run into an error, I just happened to need that one particular part to work and had my eye on all the attributes.

    I was using the Developer Tools in Chrome that come up when you hit F12, and inspecting the elements of the area I had chosen to place the plugin.

    All the text is color-coded, and I noticed that one attribute was all red, instead of red then blue for the attribute and then its value.

    From there, it was a matter of hunting down which file contained that logic.

    Plugin Author Sajid Javed

    (@sjaved)

    Hi @vincentjflorio

    Hope you are doing good today and thanks for reporting the typo error.

    Indeed I missed that part. Now I am updating the plugin please update to use responsive feature.

    Take care and have a nice weekend ??

    Cheers, Sajid

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Possible Typo in Code’ is closed to new replies.