Priority PHP_INT_MAX for woocommerce_after_calculate_totals
-
Hello,
We are another plugin developer that has encountered a conflict with your plugin. The core of the issue is the use of PHP_INT_MAX for the priority of the woocommerce_after_calculate_totals hook.
Is it possible for you to change this to a defined constant so that it can be controlled via wp-config.php ?
Or can you add a do_action() at the end of your calculations so that other plugins can still function with this plugin is installed? As it stands, our gift cards plugin breaks when your plugin is installed and I can’t find a way around it currently.
We’re open to any suggestions on how to have your plugin play nice with ours!
-
I am in the process of evaluating the Gift Cards plugin running on a local staging server that has error messages being displayed. I am using the Advanced Dynamic Pricing plugin and unless I disable it I see the error message:
“Notice: Undefined variable: redeem_hook_priority …htdocs\wp-content\plugins\pw-woocommerce-gift-cards\includes\pw-gift-cards-redeeming.php on line 41
and the checkout hangs.
I believe that you may have a mistake in your fix, shouldn’t:
add_filter( ‘wdp_calculate_totals_hook_priority’, function( $priority ) { return $redeem_hook_priority – 1; });be:
add_filter( ‘wdp_calculate_totals_hook_priority’, function( $priority ) { return $priority – 1; });
Note: $priority not $redeem_hook_priority
Hello
you have variable
$redeem_hook_priority = 40;in file pw-gift-cards-redeeming.phpso I think correct code should be
add_filter( ‘wdp_calculate_totals_hook_priority’, function( $priority ) use($redeem_hook_priority) { return $redeem_hook_priority - 1; });
- The topic ‘Priority PHP_INT_MAX for woocommerce_after_calculate_totals’ is closed to new replies.
