• Resolved lsvr

    (@lsvr)


    I came with something new regarding my previous topic. I’ve tried to just reply to that topic but the reply refused to show up so I’ve just marked it as resolved and I am creating a new topic instead. Sorry for that.

    So I did more testing and it seems like the problem lies somewhere else. “dynamic => true” seems to be working after all in 1.8.0 and the element is inserted as a shortcode (as it should). However, when I insert the element, save the page and reload the Tailor (or close and open it again, it does not matter), I do not see the element on the front-end, instead I see an error message:
    "The element associated with shortcode <strong>tailor_name_of_my_shortcode</strong> could not be found".

    Notice the prefix – “tailor_”. However shortcode’s correct tag is just name_of_my_shortcode, without “tailor_” prefix. So it seems like Tailor is for some reason prefixing “tailor_” when calling a shortcode in the Front-end editor. Again, it worked in the previous version (1.7.10).

    I’ve tracked the issue into “includes/class-models.php” file. Line 938 in generate_models_from_html function:

    'tag' => 'tailor_' . $type,

    When I remove ‘tailor_’, it fixes my shortcodes, but breaks default Tailor shortcodes. So we need to fix this function to not to hardcode “tailor_” prefix for every shortcode tag.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Munir Kamal

    (@munirkamal)

    Hi @lsvr,

    Thank you again to investigate and report this. We did some big changes in v1.8 to make tailor content editable via WordPress editor. I have raised this issue already with my team and will update you about it.

    Regards,
    Munir

    Plugin Contributor Munir Kamal

    (@munirkamal)

    Hey @lsvr,

    This should be fixed now with the latest release, could you please test again and confirm if everything is working well?

    Regards,
    Munir

    Thread Starter lsvr

    (@lsvr)

    Hi Munir,

    it is working, thanks a lot!

    Did you by any chance solved the WPengine issue as well?

    Lubos

    Plugin Contributor Munir Kamal

    (@munirkamal)

    Great. No, not yet, will look into the Wpengine issue, there is another thread open for that so I can now mark this one resolved.

    Cheers,
    Munir

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Problem with custom shortcodes in 1.8.0’ is closed to new replies.