Problem with MapPress plugin?

is this only on pages where mappress is used, or on all?

it’s likely the mappress plugin hooking into AO’s API to ensure mappress functions OK, maybe check with the developer?

Hi,

This effects all pages with or without a Map on them, I did contact the developer and they said:

I can’t say why Autoptimize might not perform as expected, but I can tell you that MapPress excludes its scripts & CSS from AO.

This is because AO mangles the scripts (which are already minified), preventing both MapPress and the Google APIs from working.

You can see the relevant code in file ‘mappress.php’, filter ‘autoptimize_filter_js_exclude’, etc.

Again – the exclusion should only be for the MapPress scripts & CSS, so I’m not sure why it would affect anything else.

So i’m not really sure where to go from here, its the moment I turn the plugin on, AO doesn’t function in the same way.

• This reply was modified 2 years, 10 months ago by Steven Stern (sterndata).

as the mappress dev confirmed his code uses the AO API to alter behavior and as the problem goes away when mappress is not active, the problem must be with how mappress integrates the AO API.

technically; it looks like mappress assumes the JS exclusions are in a comma-delimited string, but they can also be in an array instead actually, as per https://github.com/futtta/autoptimize/blob/beta/classes/autoptimizeScripts.php#L296-L312, so the mappress dev should adapt his code to take array vs comma-delimited string into account to fix your problem.

hope this helps,
frank

Hi Frank,

I’ll pass this on and let you know of any updates!

Thanks
Steven

Hi Frank,

I passed this on and Map Press made some changes which solved the problem!

Thanks for the help!

great, happy to have been able to help ??

feel free to leave a review of the plugin and support here! ??