• Resolved Ron B

    (@rwbroome)


    Hi Evan,

    Several problems that started with 1.2.5 (not a problem in 1.2.4 when I roll back plugin). This is on a staging site on my local computer.

    ——————————-

    (1)
    On FIRST post (ONLY) of timeline, I get an error and the excerpt doesn’t display AND the “Read More” url goes back to the page on which the shortcode is inserted. The error I get:

    ( ! ) Warning: date() expects parameter 2 to be long, string given in C:\Users\Ron\Documents\Websites\www.xxxxxxxxxx.dev\GWFA-EW\wp-includes\functions.php on line 112 Call Stack # Time Memory Function Location 1 0.0051 177216 {main}( ) ..\index.php:0 2 0.0054 179304 require( ‘C:\Users\Ron\Documents\Websites\www.xxxxxxxxxx.dev\GWFA-EW\wp-blog-header.php’ ) ..\index.php:17 3 0.8997 26847320 require_once( ‘C:\Users\Ron\Documents\Websites\www.xxxxxxxxxx.dev\GWFA-EW\wp-includes\template-loader.php’ ) ..\wp-blog-header.php:19 4 0.9079 27151592 include( ‘C:\Users\Ron\Documents\Websites\www.xxxxxxxxxx.dev\GWFA-EW\wp-content\themes\jumpstart\template_builder.php’ ) ..\template-loader.php:75 5 1.4112 28801200 […]

    ——————————-
    (2)
    On subsequent posts of the timeline, the “Read More” link goes to the correct post page, but the post does not display.

    ——————————-

    I am using your “timeline-express-container.php” file in a timeline-express folder in my child theme (with two customizations, one adding a class so I can customize CSS of the fly-in post box, the other adding the permalink to the title of the post). Using just your unadulterated “timeline-express-container.php” file (1.2.5) in my child theme does NOT fix this problem.

    I am NOT using a “single.timeline-express.php” file in my my child theme.

    I also was using the following custom code in functions.php of my child theme, but removing it does not affect anything either:

    //  CHANGE SLUG
    function gwfa_change_timeline_express_slug_fn ( $slug ) {
    
        $slug = 'animation-timeline';    // slug for timeline
        return $slug;
    }
    add_filter('timeline-express-slug', 'gwfa_change_timeline_express_slug_fn' );
    
    // alter 'Read more' to say 'More ->'
    function gwfa_change_timeline_express_readmore_text_fn ( $translated_text, $untranslated_text, $domain ) { 
    
        switch( $untranslated_text ) {
            case 'Read more':
              $translated_text = __( ' More ☛','timeline-express' );   //
            break;
         }
       return $translated_text;
    }
    add_filter('gettext', 'gwfa_change_timeline_express_readmore_text_fn', 20, 3);
    
    // add a custom class to the timeline express readmore link
    function gwfa_add_timeline_express_custom_readmore_class_fn ( $button_classes ) {
        return $button_classes . 'gwfa_timeline_express_readmore_btn';
    }
    add_filter( 'timeline-express-read-more-class' , 'gwfa_add_timeline_express_custom_readmore_class_fn' );

    ——————————-

    Everything worked in 1.2.4 great (even excerpt problem I reported in 1.2.1) , but this is now broken in 1.2.5.

    Thanks,
    Ron

    https://www.ads-software.com/plugins/timeline-express/

Viewing 15 replies - 16 through 30 (of 36 total)
  • Plugin Author Evan Herman

    (@eherman24)

    Yes, that it how it should work. I did do testing before pushing anything live – and was able to customize both the page template and the content itself.

    I will have to go back and re-test when I am back around the computer.

    Thanks,
    Evan

    Thread Starter Ron B

    (@rwbroome)

    Okay. Thanks. I think your paradigm is sound, I just can’t get the “single-timeline-express-content.php” file in my child theme timeline-express to be invoked.

    Ron

    Plugin Author Evan Herman

    (@eherman24)

    I am just working on getting these changes into the pro version. I am going to do some testing and make sure that things are working. I will report back here with some of my findings.

    Plugin Author Evan Herman

    (@eherman24)

    I just did a quick test with twenty sixteen theme, and I am able to override the template file ‘single-timeline-express-content.php’ inside of /themes/theme_name/timeline-express/single-timeline-express-content.php.

    I then tried duplicating the announcement page template, and overriding the announcement content – and didn’t seem to have any issues. When used together, I was able to fully customize the paeg template, as well as all of the announcement content (images/date/content etc.).

    Evan

    Thread Starter Ron B

    (@rwbroome)

    How about in the timeline-express folder of a child theme?

    I’m just copying the files from your template directory as is, to my child theme timeline-express subfolder.

    R

    Thread Starter Ron B

    (@rwbroome)

    The “single-timeline-express.php” works in the child theme timeline-express subfolder.

    The “single-timeline-express-content.php” does not, and it appears to default to the standard single.php.

    R

    Plugin Author Evan Herman

    (@eherman24)

    Yea, that’s strange. During my testing I am not hitting that issue.

    Thread Starter Ron B

    (@rwbroome)

    What is the second argument in the call to

    get_timeline_express_template( 'single-announcement' );

    in “single-timeline-express.php”?

    Can it be set to another template name?

    R

    Thread Starter Ron B

    (@rwbroome)

    didn’t mean ‘second’

    Plugin Author Evan Herman

    (@eherman24)

    There is only one parameter for that function, and it is the template name that should be retrieved:

    https://github.com/EvanHerman/timeline-express/blob/cb7d663b91f6c56ed07c9c33b5e2d72543d25478/lib/helpers.php#L263-L290

    There are only two templates that are possible to retentive by that function.

    Thread Starter Ron B

    (@rwbroome)

    I tried changing the arg to ‘single-timeline-express-content’ and very strangely it pulled the template “timeline-express-container.php”.

    R

    Plugin Author Evan Herman

    (@eherman24)

    I am testing with a TwentyFifteen child theme now.

    Plugin Author Evan Herman

    (@eherman24)

    That is correct, because single-timeline-express-content is not a template that can be selected, so it falls back to the default “timeline-express-container.php”.

    Your possible options are ‘timeline-container’ and ‘single-announcement’.

    Thread Starter Ron B

    (@rwbroome)

    Could the “default” location in the switch statement be causing problems? I usually don’t put them at the beginning.

    Plugin Author Evan Herman

    (@eherman24)

    It doesn’t make sense that it’s working on my end and not yours. I won’t be able to replicate and resolve the issue without access to the theme on my end.

    Any themes that I test with appear to be working.

    Thanks,
    Evan

Viewing 15 replies - 16 through 30 (of 36 total)
  • The topic ‘Problems in v1.2.5’ is closed to new replies.