Problems in v1.2.5

After some thought, it’s possible that the template file you are using is the proper one.

Is there a loop going on inside of that file?

Something like:

if ( have_posts() ) {
   while ( have_posts() ) {
     // etc.
   }
}

I believe this is required for the timeline announcement content to be properly retrieved and displayed on the page.

It is the “single-timeline-express.php” file I copied from the template directory of the plugin. The code is:

get_header(); ?>

<div id="primary" class="content-area timeline-express-content-area">
	<main id="main" class="site-main timeline-express-main" role="main">
		<?php
		// Start the loop.
		while ( have_posts() ) : the_post();

			?>
			<header class="entry-header">
				<?php the_title( '<h2 class="entry-title">Film: ', '</h2>' ); ?>
			</header><!-- .entry-header -->

			<div class="entry-content">
			<?php
				// Include the single post content template.
				get_timeline_express_template( 'single-announcement' );
			?>
			</div>

		<?php
		// End of the loop.
		endwhile;
		?>

	</main><!-- .site-main -->
</div><!-- .content-area -->

<?php get_footer(); ?>

I changed h1 to h2 and added “Film: “.
That part works.

Ron

Inside of your theme, what are the template files there? Do you see a single.php? Try using that template, and replacing the_content() or get_template_part().

Evan

So, I determined that the “single-timeline-express-content.php” file is loading. It seemed like it was/should be, but I couldn’t see any effects of mods from the “single-timeline-express-content.php” file. (Lot of old-school inserting of echo’s to find that out).

Okay, so I figured it out. I should have figured it out sooner, but didn’t realize how wound up some things got.

1) There was a collision between template loads for single TE posts that I had created as a workaround for when TE version 1.1.x didn’t support a single post template. I was loading another template, that now didn’t load with your new one, but it looked like single.php was loading (which I don’t actually use anywhere). I unwound that change, and the “single-timeline-express-content.php” file loaded without an issue, but I still could not see that because…

2) Regardless of image size you retrieve with
timeline_express_get_announcement_image( get_the_ID(), 'full' ), the size of the image is now set to display width:100% by the announcement-banner-image class in 1.2.x TE CSS. I did not see that because I was overriding the image size a different way during the older version of TE. The image size looked like the default single.php and had the same lack of CSS or wrapper classes.

It would probably be good to remove the width:100% as this sort of defeats having a flexible image size load. Perhaps max-width:100% width:auto )

and…

3) the <strong class="timeline-express-single-page-announcement-date"> class tag in line 26 of “single-timeline-express-content.php” sets display:block. This was being re-styled in my older version to handle changes my client wanted, but this caused a display position problem in this new version…and weirdly it wasn’t showing in the CSS inspection.

————————-

The short of it is that it now all works, once I figured out to unwind ALL of my previous TE 1.1.x kluges.

I probably would have seen this sooner, but I’m multi-tasking under the gun to get this project wrapped. Never fun when new updates to stuff happens just before a release.

The way you have the plugin now really is way better.

So, sorry, for having this chasing our tails. Arrrggg.

Ron

One last thought.

While the images should be sized to width:auto, really with what you are trying to do, you should consider using the srcset attribute and just make it automatic. Better for responsive websites.

Ron

Ah that makes complete sense. Sorry there was so much trouble during the migration, but I’m glad you finally got things sorted – and helped me catch a few bugs along the way.

I will look into implementing the srcset attribute for responsive images. That’s a good point. And I’ll get the width auto set up in the next patch.

Thanks again,

Evan