Problems With P2

Just wanted to confirm the issue with ‘reply’ not working in Safari 4, Flock2 and FF3 on a Mac or Windows XP. Here’s a test site. Ignore the content, it’s there for testing a different theme:

https://test.blogs.lincoln.ac.uk/

I found three problems with P2 theme 1.0.3

(1) There are two shorthand PHP tags. Because my server is “short_open_tag = Off”, a PHP parse error was occur.

The fix point is below.

* line 429 of functions.php
<div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?}?>"....

should be:
<div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?php } ?>"

* line 27 of entry.php
<div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?}?>"...
shoud be:
`<div class=”postcontent<?php if (current_user_can( ‘edit_post’, get_the_id() )) {?> editarea<?php } ?>”

(2) The language resource for ‘Updates from %s’ has double meanings. In archive.php, %s represents time. In author.php, %s represents a person.
In some language (like Japanese), The translated strings will be different for this resource.
I suggest using _c() function and conditional resource like below:

* for archive.php: _c('Updates from %s|month', 'p2')
* for author.php: _c('Updates from %s|name', 'p2')

(3) The prologue_navigation() function in function.php does not work with single.php because posts_nav_link() is for multiple posts (not for singuar). But, the prologue_navigation() is located at single.php.
I suggest remove this, or replace with previous_post_link(), next_post_link().

@lilyfan, thank you so much for the great suggestions and good finds. It’s the smallest mistakes that make the biggest difference.

Just a minor point. I’ve noticed that in Safari 4 and FF 3.5b, that the search box on P2 has ‘Search for:’ positioned outside the search box. Looks like a minor CSS aberration.

@lilyfan
you fixed my problem with functions.php and entry.php ??
(https://www.ads-software.com/support/topic/262139)
(line at functions.php is 724, not 429)

thanks!

@lilyfan
Thank you!
Fixed my problems also @ https://www.ads-software.com/support/topic/263128?replies=3

Just realised that the ‘reply’ link is working for me on 2.7.1 but not on the trunk version of WP (which I run my blog on).

Excellent theme, really gets the mind working on possibilities…

Is it our imagination or does the “Dynamic Post Updating” (that can be seen by other users without having to refresh the page) not work when installed locally…?

We were hoping to use the theme on our internal intranet and were wondering if anyone else has the same problem or knows of a way to get this function to work when installed locally (we are using XAMPP)…?

OK, now I feel stupid… ??

It seems that if both users are logged-in, the updates do appear cross browser without refreshing…

Is that specific to the theme or just to local installs…?

Any other issues, tweaks or concerns with anyone specifically installing and using P2 locally…?

I’ve some problems with the P2 theme.

1) When on a author url (like domain.com/author/admin) the form to post is unavailable

2) If I close all comments and reload the page, the comments are still open. This setting should be remembered, using cookies.

3) When on a author url all comments are closed by default. When clicking “show comments” they dont show up (nothing happens)

@ni-limits the theme’s ajax dynamic updating is specific to the theme, not the install. It only works if both users are allowed to see the content and if comments need to be dynamic they need to be un-moderated.

@niska: 1) that is intended 2) since most users might not remember that they turned this off, we decided to make it only stick for the one window session 3) could you provide a url where this is happening? I can not reproduce this error.

@noel
1) Look at Twitter. Users can post on their own “author page”. Why would you like users to only post at the front page?
2) Session-setting seems like a good idea. But for me, it doesn’t work at all (using the latest version of P2). The setting is not remembered. I’ve checked my cookies and couldn’t find anything. Other wordpress cookies are there. Maby a bug?
3) My project is not public yet. Sorry.

@noel I’ve found the reason for my problem 3) above. I’m using the subdomain plugin. And when on a subdomain, ajax calls doesn’t work because of this line in functions.php

var ajaxUrl = "<?php echo js_escape( get_bloginfo( 'wpurl' ) . '/wp-admin/admin-ajax.php' ); ?>";

Could you use the current hostname instead of wpurl? Like this:

var ajaxUrl = "<?php echo js_escape( 'https://'.getenv('HTTP_HOST').'/wp-admin/admin-ajax.php' ); ?>";

Or something similar (I’m not a wordpress coder)

Thanks!

Another (easy to fix) problem with P2 ??

Could you please filter out shorttags from the post slug?

@noel – yeah, thanks for the explanation…

Will take a closer look under the hood next time before jumping in… ??