Bug with duplicate fee names.

Hi Sogwap,

Yea, I have come across this issue as well. The problem is that there is no other parameter to invisibly identify them as separate fees: https://github.com/woothemes/woocommerce/blob/3e55364e3a1ecf0dc93bd796c51cd85093de5127/includes/class-wc-cart.php#L1909

I could add in the SKU’s to be appended, but I have a feeling most would not like how that looks. The addition idea could work though. Let me look into this, and see what the best solution available is.

In the meantime, you could manually add in the SKU’s to the fee name.

I’m gonna see if this is something that should be added to core actually. Issue created here: https://github.com/woothemes/woocommerce/issues/9193#issuecomment-142116874

Since I have only one type of fee I made one change in file:
/wp-content/plugins/woocommerce-product-fees/classes/class-woocommerce-product-fees.php

From this:

// Send multiplied fee data to add_product_fee()
$this->add_product_fee( $new_product_fee, $product_fee_name );

To this:

// Send multiplied fee data to add_product_fee()
// $this->add_product_fee( $new_product_fee, $product_fee_name );
$this->add_product_fee( $new_product_fee, ‘Bottle Deposit Item #’ . $product_id );

Obviously not ideal. But a simple quick fix in my situation.
In essence it changes the $product_fee_name to fixed name and append the $product_id

Oh, there is a better way to achieve that though.

If you want the fees to be named like this: https://cld.wthms.co/1fGEM/FlxOJhGY, then try the following snippet in your child theme’s functions.php file:

add_filter( 'woocommerce_product_fees_filter_fee_data', 'wc_ninja_prefix_fees' );

function wc_ninja_prefix_fees( $fee ) {

	$fee['name'] = 'Bottle Deposit Item #' . $fee['product_id'];

	return $fee;

}

It hooks into a filter in the plugin so you do not have to override the core files. We are hooking into this filter: https://github.com/WPprodigy/woocommerce-product-fees/blob/master/classes/class-woocommerce-product-fees.php#L143, and returning the fee with an altered name.

In other news, I believe WooCommerce core will soon be able to just add the fees together when they are the same name.

It looks like WooCommerce core will not be adding this in, so I added in this feature into version 1.1.1.

https://github.com/WPprodigy/woocommerce-product-fees/commit/2003850b0f6834050776994b4735809ba59bcb95

Hi all,
Great plugin, thank you to the developer for taking time to create this.
I found a bug just like explained above.
The problem is the fee will calculate for items with similar names eg evie bottled water fee ￡3, evie cookies fee ￡2, evie mixed herbs ￡5 etc but soon as an item with a different name is added to cart eg cosmo ice cream fee ￡6 etc it won’t calculate the fee for the cosmo ice cream leaving the total fee in the cart as ￡3+￡2+5=￡10 rather than ￡3+￡2+￡5+6=￡16.
I hope this makes sense.

https://www.ads-software.com/plugins/woocommerce-product-fees/

Hi gadgetx,

I’m not sure I understand. When you have 3 different fees, they all three get added. But on the fourth fee it is not getting added?

Yes, that’s right.

I cant’ replicate this issue. Adding 4 fees works fine for me: https://cld.wthms.co/1fcMe/2wipRWuW

Am I missing something? Perhaps try explaining your issue again with a bit more detail.