• Resolved Jeff Sterup

    (@foomagoo)


    The profile picture on our Facebook feed randomly stops loading. To fix this someone has to go in and manually clear the cache. I started troubleshooting how to fix this by making the cache time shorter. When I got into your code I noticed that the cache time is always set to 15 minutes regardless of what I set on the settings page. I uncommented your debug code at line 171 in the file /feed-them-social/includes/feed-cache.php. The $cache_time_limit variable is always set to 900 even though I’ve set the limit to 1 day on the settings page. I can see that reflected in the database as well when I check the transient timeout expiration time for the feed caches. So that means first off it isn’t honoring the time set by me on the settings page and second I can’t set the cache time shorter because it will never honor the value I return from the filter on that value. The problem seems to come from your logic on line 169 of that file:

    $cache_time_limit = true === $this->settings_functions->fts_get_option( 'fts_cache_time' ) && '1' !== $this->settings_functions->fts_get_option( 'fts_cache_time' ) ? $this->settings_functions->fts_get_option( 'fts_cache_time' ) : '900';

    This expression will never set the variable to the value returned from $this->settings_functions->fts_get_option( ‘fts_cache_time’ ) because it will never evaluate to true since it’s a string representation of a number and not a boolean.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author slickremix

    (@slickremix)

    Jeff,

    Thank you so much for taking the time to look into the caching issue you mentioned. I will investigate further and get back to you. Have a great day!

    Spencer

    Plugin Author slickremix

    (@slickremix)

    Jeff,

    Again, big thanks for bringing this issue up. I have no clue why that line was even checking if the option set was true; that is totally unnecessary. I will push an update in the next few days to correct this.

    Plugin Author slickremix

    (@slickremix)

    Thanks again for letting me know about this. I made an update and gave you a shout out on the readme file. Have a good one man! https://www.ads-software.com/plugins/feed-them-social/#developers

    Spencer

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.