Pull request: fix proposal

  • Hi,
    I’d like to suggest a fix to the plugin code. I looked for a repo on github to make a pull request but I couldn’t find it, so I’m writing here.

    In icegram.php main file, inside icegram_load_data() function, there is this line (n.521 in v.1.9.7.1) where you set the js object properties:

    $icegram_pre_data['post_obj'] = $_GET;

    In our environment, the $_GET is not always an array, because of server setup and other plugin filters. And when it’s not an array the object properties are not properly set and the Icegram retargeting routine does not work as expected.
    So simply I suggest an explicit type-casting and the patched line should be:

    $icegram_pre_data['post_obj'] = (array)$_GET;

    In this way it’s always working.

    I hope you can accept and include it in next release.

    https://www.ads-software.com/plugins/icegram/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Icegram

    (@icegram)

    @eventualo

    Thank you for pointing out this.
    We will surely look into this and incorporate in Icegram.
    It will be fixed in next release.

    Thanks,
    Sandhya
    Team Icegram

    Thread Starter eventualo

    (@eventualo)

    Hi, the fix was not included in 1.9.8.1, isn’t it?

    Plugin Author Icegram

    (@icegram)

    Hi,

    Sorry, we have not included in our last released version.
    Once we verify this fix with all use cases then only we will include in our future release version.

    Thanks,
    Nishit Shah
    Team Icegram

    Thread Starter eventualo

    (@eventualo)

    News about it? Thanks

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Pull request: fix proposal’ is closed to new replies.