Query Monitor PHP warning

Similar error for post_type on the following line.

Furthermore, I don’t think all the post_ids that are passed are actually post ids. Some are term_ids, so the title lookup is getting the title of a post with the same id as that term.

Those which are term_ids are probably identified by context=terms so something like the following code in the “output_post_restrictions” might help

			if ( 'terms' === $post_data['context'] ) {
				$term = get_term( $post_id );
				$name = $term->name;
				$type = 'TERM';
			 } else {
				$post = get_post( $post_id );
				$name = $post->post_title;
				$type = $post->post_type;
			 }

Then use $name and $type in place of $post->post_title/type respectively.

For terms it might help to indicate the taxonomy they come from, e.g.

$type = 'TERM/' . $term->taxonomy;

Column titles might also need revising to be more generic, e.g. ID, Title/Name, Type

@peter8nss – Do you happen to know how you triggered this? I have QM on 100% of the time during development and haven’t come across this, there must be a conflict or config set that were are not testing against.

Furthermore, I don’t think all the post_ids that are passed are actually post ids. Some are term_ids, so the title lookup is getting the title of a post with the same id as that term.

Very possible, the QM integration was added before TermQuery processing was added. I’ll have to rework that a bit to ensure we keep term & post lists separate.

For terms it might help to indicate the taxonomy they come from, e.g.

Column titles might also need revising to be more generic, e.g. ID, Title/Name, Type

Excellent ideas.

I think my original assumption about the problem coming from null post_id values was incorrect. I think all the cases I saw were actually term_id values. And if you pass a term_id to get_post and there isn’t a post with the same id, then it returns null. Hence, the PHP warnings.

You will only see it if the page you are viewing involves a query and that term_ids from that query don’t have posts with the same ids.

I’ve been running with my suggested code changes to “output_post_restrictions” and that clears the PHP warnings.

@peter8nss – Super helpful thanks. Will get this patched.

@peter8nss – I added your simple change proposed above for now, but I think in a near future version we will completely separate how we handle terms, specifically adding internal get_term methods and separating those concerns into separate specific handlers.