Question about 'oembed_dataparse'

  • Resolved George Notaras

    (@gnotaras)


    8 years, 10 months ago

    @swissspidy

    Hello Pascal and thank you for this plugin.

    I noticed that the following exists in the source code:

    remove_filter( 'oembed_dataparse', 'wp_filter_oembed_result', 10 );

    Is wp_filter_oembed_result specific to the functionality as an oEmbed provider or does it also affect embedding other media from external services?

    From what I read about wp_filter_oembed_result:

    Filters the given oEmbed HTML.

    If the $url isn’t on the trusted providers list, we need to filter the HTML heavily for security.

    Only filters ‘rich’ and ‘html’ response types.

    It’s not very clear whether it affects the provider or client functionality.

    Would giving the removal of this filter a second thought be a good idea or am I missing anything here?

    Thanks in advance!

    George

    https://www.ads-software.com/plugins/disable-embeds/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Pascal Birchler

    (@swissspidy)

    Hi George,

    The Disable Embeds does not disable all embeds functionality, it just reverts the changes made in WordPress 4.4.

    It’s not very clear whether it affects the provider or client functionality.

    This only affects client functionality. It means that you no longer can embed from any source, but only from trusted providers like YouTube, Twitter, Facebook, et al — just as before.

    Theoretically, the remove_filter( 'oembed_dataparse', 'wp_filter_oembed_result', 10 ); line is not needed because of add_filter( 'embed_oembed_discover', '__return_false' );. But again, this plugin reverts all the changes made in 4.4.

    Hope that helps!

    Thread Starter George Notaras

    (@gnotaras)

    Hi Pascal and thanks for your fast reply!

    This only affects client functionality. It means that you no longer can embed from any source, but only from trusted providers like YouTube, Twitter, Facebook, et al — just as before.

    Oh I see. I should have guessed so. Thank you for the clarification!

    George

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Question about 'oembed_dataparse'’ is closed to new replies.