• Resolved dxlwebs

    (@dxlwebs)


    Hi i noticed that after an update not sure when this happened but if there is a space in the tab tittle when you update the page wit the short code in it, %20 gets put in place of a space for the titles of the tabs so to fix it i added in a quick fix until you see fit to add something a bit better than my quickies ??

    tabby-responsive-tabs line 169 i added
    $titles = str_replace('%20', ' ', $title);
    then on lines 199 and 204 changed title to titles

    its fixed my issue for now might help some others and the coders

    https://www.ads-software.com/plugins/tabby-responsive-tabs/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author cubecolour

    (@numeeja)

    I have not been able to reproduce this issue on my test sites, and none of the owners of the 20,000+ sites the plugin is used on has mentioned a similar problem, so I will not be editing the plugin to include your suggested change.

    Have you checked whether the issue also occurs when you have a default theme active on your site and with no other plugins active? If not, try that and if the issue no longer occurs at that time, switch your theme back and enable you plugins one by one until the issue reoccurs to identify what has causing this on your site.

    Thread Starter dxlwebs

    (@dxlwebs)

    I didnt mean any disrespect, and for your information most of the time if there is a issue with an plugin i don’t waste my time trying to fix the issue, i normally remove it and find a different one, but as i like your plugin i fixed the issue and thought i’d let you know about it, im not going to deactivate all the plugins and change my template, as i’m running an extremely big multisite network and bringing it down will cost me a lot of money, this fix i provided was just a “Hey by the way” post and considering that implementing it takes 5 seconds and does not effect anything in your plugin but stops the 1% that have got the issue that i had. Anyways it’s your plugin leave the issue in there.

    Plugin Author cubecolour

    (@numeeja)

    I could not reproduce this issue on my test sites. Had I been able to reproduce the issue I would be able to investigate the cause, and if this was something that could be fixed within the plugin I would update the plugin. Doing the string replacement doesn’t seem like a good fix to me; it would be preferable to find out what is causing the space to be replaced in the first place and applying a fix to the code that is causing it rather than changing it back. If you were willing to investigate the cause of the issue on your site, the code that needs fixing could be identified and a proper fix could be investigated rather than a workaround

    The actual percentage of sites using the plugin where this issue has been reported is actually below 0.005% (ie exactly one site out of over 20,000 using the plugin) so I’m not sure where you got your figure of 1% from.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘quick fix for 20’ is closed to new replies.