Recursive sub_fields fix

  • Resolved doublesharp

    (@doublesharp)


    4 years, 11 months ago

    The acfe_bidirectional_setting_find_related() function in includes/field-settings/bidectional.php is returning early in the sub_fields loop.

    Moving the return after the loop will check all sub_fields:

    
    // Recursive search for sub_fields (groups & clones)
    if(isset($r_field['sub_fields']) && !empty($r_field['sub_fields'])){
        
        foreach($r_field['sub_fields'] as $r_sub_field){
            
            // Recursive call, populates $choices
            acfe_bidirectional_setting_find_related($r_sub_field, $r_field_group, $choices);
            
        }

        return;
        
    }
    • This topic was modified 4 years, 11 months ago by doublesharp.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Konrad Chmielewski

    (@hwk-fr)

    Hello,

    Oh yeah, I haven’t noticed that it stopped after finding a compatible sub field! Thanks for the report, I will add it in the next patch.

    Have a nice day!

    Regards.

    Plugin Author Konrad Chmielewski

    (@hwk-fr)

    Hello doublesharp,

    Just to let you know that the latest ACF Extended 0.8.3 Update added your fix ??

    Have a nice day!

    Regards.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Recursive sub_fields fix’ is closed to new replies.