Regenerate Thumbnails creates duplicate files every time it is run

  • When I regenerate thumbnails using that plugin, it creates a new file. I am creating webp files, and works pretty great, but every time I do that to update existing files, it adds to the end of the filename: “-oldext.webp”, but it does it even to previously generated webp files. If you run it once, it changes filename.jpg to filename-jpg.webp. If you run it a second time, it creates a new file instead of replacing the existing, and changes the name to filename-jpg-webp.webp. A third time gets you filename-jpg-webp-webp.webp.

    It isn’t the end of the world, it is manageable, but would be nice if it didn’t keep creating new files every single time. For now, we won’t run it site wide more than once.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Weston Ruter

    (@westonruter)

    Interesting. At first I thought you were reporting this issue https://github.com/WordPress/performance/issues/545

    But it seems to be a deeper problem than that. I suggest commenting on that issue with what you’ve written above.

    Thread Starter Jupitercow

    (@jcow)

    I did see that request. I like the idea of control over the extension, but I don’t mind having “-jpg” or “-png” kept as a reference to where the file came from…

    The issue here seems to partially be that it converts webp files to webp and then keeps adding to the extension. I just had a problem where somebody added a banner image to a site that was already webp format, and when I ran regenerate on the site, it broke those images. Likely due to a CDN conflict. Working on that now.

    It seems like it would be ideal to leave existing (either uploaded or converted) webp images alone, but I might be missing something. I will comment on the github thread.

    Thread Starter Jupitercow

    (@jcow)

    I realize after thinking about it that when we regenerate images, we want to regenerate them all, so obviously it has to regenerate existing webp images. I was too focused on what I was doing and not how this plugin needs to work. Just needs to not change the filename when it is already a webp. Great plugin either way.

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.