Reinstallation failure

  • If one ever has to reinstall, they first have to remove leftover DB info from settings. Right?
    scripts/database.php starting form line 10:

    // CHeck the DB version of the plugin
$current_qtl_db_version = get_option( 'qtl-db-version' );

if($current_qtl_db_version==false) // add the option and create DB
{
	AI_Quiz_db_create();
	add_option( 'qtl-db-version', $this_qtl_db_version);
}
elseif($current_qtl_db_version<$this_qtl_db_version) // update the option and update DB
{
	AI_Quiz_db_create();
	update_option( 'qtl-db-version', $this_qtl_db_version );
}

    Shouldn’t you be checking if tables actually exist, rather the version number they used to be before removal?

Viewing 1 replies (of 1 total)
  • Plugin Author Alex Furr

    (@alexfurr)

    Yes that would make sense i.e. it never downgrades.
    I’m not an expert on database etiquette when downgrading, should it really delete columns not in late versions?

    I’ll see what other plugins do, but I was led to believe this was best practice i.e. look at the version number rather than if tables exists.

    Alex

Viewing 1 replies (of 1 total)
  • The topic ‘Reinstallation failure’ is closed to new replies.