Renew Button keeps renewing

Considering this update for core:
https://github.com/strangerstudios/paid-memberships-pro/commit/0a97ba09af512984aa8fcddb52d6e618603df92d

Let me know what you think.

I thought we could use that new pmpro_isExpiringSoon() function via the pmpro_registration_checks hook to keep people from checking out if they would be renewing too early, but there are a number of addons (PMPro Addon Packages and PMPro Gift Memberships) which rely on allowing users to checkout for their current level multiple times (and those plugins handle it so they aren’t extending their membership)

So I think we can do that, but I might introduce this first to get it adopted, then update the addons to use this plugin, then update core again to keep people from renewing early.

You could write that code yourself to use in a custom plugin. Generally hook into pmpro_registration_checks, check if the current user is logged in and checking out for the level they already have and if(pmpro_isExpiringSoon($current_user->membership_level))

Hope this helps.

Concept sounds good..
Not sure on the concept of allowing users to checkout for their current level multiple times and why how it works as havent used it.

But yes to be able to hide the Renew button ( even as a tick option) to stop what have happened above.
If a tick option is used then I guess you would need code to over ride each members Renew button to ‘turn it back’ (the day before or at time of email being sent to say Renewal is required) on until they renew. Then hide it again til the renewed subscription is due to expire again..
For all any level of Free or Paid memberships as well..

I guess if they are a paid member and want to renew ( before time), then the owner of the site will get paid early. To his advantage. And is a day giving members long enough or do they need more time..

mmm needs more thinking I guess