Reposting bug report – credit not defined

  • Well, that’s odd – the forums seem to have marked my post as closed before it’s even been opened.

    So, reposting my simple bug report:

    On line 96 of yahoo!-wheather.php, if credits are not shown, $credit is undefined, throwing a “Notice: Undefined variable” when WP_DEBUG is set to true.

    The simple fix is to define it as empty on the previous line, ie:

    $credit = '';
if ( $show_credit ) $credit = ' & <a href="https://zourbuth.com/plugins/yahoo-weather/">zourbuth.com</a>';

    Cheers,

    Christian

    https://www.ads-software.com/extend/plugins/yahoo-weather-forecasts/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    Well, that’s odd – the forums seem to have marked my post as closed before it’s even been opened.

    Spam filter. It happens and I’ve un-spammed this post.

    If the credits are not opt-in (they had better be) then this plugin violates the terms of hosting a plugin on www.ads-software.com’s repository.

    https://www.ads-software.com/extend/plugins/about/guidelines/

    If that’s not the case (I’ve not yet installed this plugin) please report it to [email protected] or perhaps the author will reply to this topic.

    Thread Starter Christian Wach

    (@needle)

    Sad to report that credits are opt-out. Perhaps it’s a simple oversight. I’ll wait a while for the author to reply before reporting.

    Cheers,
    Christian

    Plugin Author zourbuth

    (@zourbuth)

    Hi needle, since this widget uses the Yahoo! Weather Forecast feeds, Yahoo need an attribution to it https://developer.yahoo.com/weather/#terms.

    Thread Starter Christian Wach

    (@needle)

    Hi zourbuth, I don’t have any say over the WordPress hosting terms – your plugin has been flagged because the bug report I submitted went through forum moderation.

    My guess would be that if the plugin has to violate the Yahoo terms to be included in the WordPress plugin directory, then it should be removed. Either that, or you need to sort out the attribution issue with Yahoo themselves, since it is presumably in their interests to have a plugin in the directory that uses their weather API.

    Cheers,
    Christian

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Reposting bug report – credit not defined’ is closed to new replies.