Request for code corrections

  • Resolved Website Rob

    (@website-rob)


    5 years, 2 months ago

    Greetings,

    You’ve got the makings of a nice Plugin. Updating some of the code would make it much better. Here are some examples.

    Using WP 5.3 and plugin v2.0.6 on Apache and PHP v7.2

    Admin -> Xtra Settings – follow errors on page load:
    Warning count(): Parameter must be an array or an object that implements Countable

    wp-content/plugins/xtra-settings/admin-setting.php:573
    xtra_get_image_quality()

    wp-content/plugins/xtra-settings/admin-setting.php:553
    xtra_get_images()

    wp-content/plugins/xtra-settings/admin-setting.php:1534
    xtra_html_page()

    Warning (Suppressed) exif_read_data(CellPhones.jpg): Incorrect APP1 Exif Identifier Code 1
    wp-content/plugins/xtra-settings/admin-setting.php:572

    On the front-end:
    Notice WP_Admin_Bar::add_node was called incorrectly. The menu ID should not be empty. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.)

    17 times wp-includes/functions.php:4903 Plugin: xtra-settings
    – I know this was reported in a previous support thread where you stated it wasn’t related to your plugin–but it appears that somehow it is.

    Deprecated Function create_function() is deprecated 1
    wp-content/plugins/xtra-settings/xtra.php:2227
    wp-settings.php
    wp-settings.php:360

    If the plugin is disabled, all the above goes away.

    To see the above I used the Plugin: Query Monitor (https://www.ads-software.com/plugins/query-monitor/)

    Cheers,

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author fures

    (@fures)

    Thanks for your comments.
    Next release will solve PHP 7+ warnings and notices (I hate all those if-s… ??
    I plan to issue it today.

    Plugin Author fures

    (@fures)

    Some more php 7+ notices/warnings cleared in version 2.0.8 (I hope most is cleared now.)
    Thank you for reporting.

    Thread Starter Website Rob

    (@website-rob)

    Greetings,

    Now using PHP 7.3 and your version 2.1.1

    No errors or warnings showing on any pages. Your updates work well — nice going.

    What I do see are 972 Notices for “Undefined Offset”.
    wp-content/plugins/xtra-settings/xtra.php starting at line #4055 to #4071.

    We know these are not necessarily breaking anything and I mention them as they do indicate the coding needs to be tweaked a bit. ??

    Plugin itself is working great although I do have a question.

    Under the Speed Tab – 7. Memory and PHP Execution
    PHP Memory limit (current: 256MB – obviously, does not work) <- I don’t understand the last part

    Plugin Author fures

    (@fures)

    Thanks, I made code corrections in version 2.1.3

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Request for code corrections’ is closed to new replies.