Seems to break existing paragraph blocks (with a custom font size)

  • Resolved Benny

    (@bvl)


    5 years, 2 months ago

    On a blank WP installation without any plugins active I added a paragraph block and gave it a custom size of 30.

    When I then activate Kioken Blocks the paragraph block breaks.

    The editor says: This block contains unexpected or invalid content and there are some errors shown in the console.
    See: https://pasteboard.co/IwVOtWS.png

    So it seems Kioken inserts an extra attribute [“class”, “has-custom-size”, true] which isn’t present in the generated output of the ‘save’ function.

    • This topic was modified 5 years, 2 months ago by Benny.
    • This topic was modified 5 years, 2 months ago by Benny.
    • This topic was modified 5 years, 2 months ago by Benny.
    • This topic was modified 5 years, 2 months ago by Benny.
    • This topic was modified 5 years, 2 months ago by Benny.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Onur Oztaskiran

    (@sj_o)

    Hi Benny,

    Thanks a lot for reporting this. I will look into that.

    Plugin Author Onur Oztaskiran

    (@sj_o)

    Ok I was able to reproduce this issue.

    However fixing it would then break validation for other paragraphs for existing Kioken Blocks users if they have custom size applied in their blocks.

    I’ll see what I can do.

    Thread Starter Benny

    (@bvl)

    Yes, I see (and know) the dilemma.

    In my own coded blocks I would use ‘block deprecation ‘ but I am not sure if this is also possible in the context of extended core blocks?

    Plugin Author Onur Oztaskiran

    (@sj_o)

    Exactly.

    I’ll post a github issue about this in the Gutenberg repo, and see what they say.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Seems to break existing paragraph blocks (with a custom font size)’ is closed to new replies.