Separate identical combined files for different pages.

  • Resolved eugene212

    (@eugene212)


    1 year, 3 months ago

    Hi there,

    While testing/using the plugin, I have observed that it seems to create a separate (but identical in its content) combined files for different pages if they use the same assets.

    This seems to be not an efficient way in two ways:
    1. Increased amount of storage for effectively the same assets.
    2. Since combined files have different names, a browser does not (cannot) use cache of already loaded page for other pages and has to load a different combined file (for the same underlying assets).

    Can you please have a look ?

    • This topic was modified 1 year, 3 months ago by eugene212.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Venkat Raj

    (@webulous)

    @eugene212 We create a hash based on enqueued assets on a particular page, and use it to create a minified/combined asset name. On subsequent pages, new asset will be created only if the hash it different (i.e. different assets are enqueued).

    So, could you please write down the exact steps to reproduce the issue? Thanks!

    Thread Starter eugene212

    (@eugene212)

    The steps are rather ordinary:
    1. Set ‘on’ JS and CSS minifying/combining.
    2. Clear all cache (both page and minification).
    3. Preload cache and observe plugin message about processed pages.
    4. Inspect processed files and observe different (CSS) files with identical underlying assets:
    https://ibb.co/kxrHGSX

    …and these different (but identical underlying assets) files are loaded on different pages – observed via Chrome Dev Tools / Network tab.

    • This reply was modified 1 year, 3 months ago by eugene212.
    Plugin Contributor Venkat Raj

    (@webulous)

    @eugene212 It only happens with Colibri page builder. So, I setup a site to test this. Created two pages using Colibri builder. It is true that it seems like identical assets are created, however if you compare the contents of the assets, you can see the difference.

    Further digging into that, Colibri adds different inline styles for different pages with same handle. So, since the content is different, WP-Optimize creates separate set for each page.

    https://ibb.co/mG8YYDW

    https://ibb.co/ZmFpTfp

    https://plugins.trac.www.ads-software.com/browser/colibri-page-builder/trunk/extend-builder/assets.php#L352

    Thread Starter eugene212

    (@eugene212)

    Thanks for the clarification !

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Separate identical combined files for different pages.’ is closed to new replies.