Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Hi, Sorry for the late reply. For some reason I didn’t get a notification.

    So if I understand you correctly, you’re saying the country and visibility settings are not staying set. Is that right? Please email me at [email protected] so we can figure out what’s going on.

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Ok, Plugin is broken in 4.5. I’m working on a fix.

    This plugin is literally the solution to all of my wordpress problems. Looking forward to use it, any eta of the fix? ??

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Hi gerdhansen2, I’ll work on it tonight and see what I can come up with.

    In 4.5, WordPress added the following code to wp-admin/nav-menus.php, and for some reason yet to be discovered, it breaks the plugin.

    /*
     * If a JSON blob of navigation menu data is found, expand it and inject it
     * into <code>$_POST</code> to avoid PHP <code>max_input_vars</code> limitations. See #14134.
     */
    if ( isset( $_POST['nav-menu-data'] ) ) {
        $data = json_decode( stripslashes( $_POST['nav-menu-data'] ) );
        if ( ! is_null( $data ) && $data ) {
            foreach ( $data as $post_input_data ) {
                // For input names that are arrays (e.g. <code>menu-item-db-id[3]</code>), derive the array path keys via regex.
               if ( preg_match( '#(.*)(?:\[(\d+)\])#', $post_input_data->name, $matches ) ) {
                    if ( empty( $_POST[$matches[1]] ) ) {
                        $_POST[$matches[1]] = array();
                    }
                    $_POST[$matches[1]][(int)$matches[2]] = $post_input_data->value;
                } else {
                    $_POST[$post_input_data->name] = $post_input_data->value;
                }
            }
        }
    }
    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Ok, I just found out this is due to a bug in WP core. You can fix it for now by deleted the code above in wp-admin/nav-menus.php, or wait for WP to provide a fix.

    https://core.trac.www.ads-software.com/ticket/36590

    Thread Starter doyenwilliams

    (@doyenwilliams)

    Hey Ryan,

    For some reason I also did not get a notice – not until gerdhansen2’s reply that is. Apologies for the delay on my side as well.

    Glad to have hope for a fix.

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Hi doyenwilliams,

    Word is the fix will be released with WP version 4.5.2. No ETA yet but it should be pretty soon.

    In the meantime, you can simply delete the code I mentioned above and the plugin will work right away. (Unless you plan to create more than 70 menu items, removing the code won’t break anything, and it will be updated with the new WP version)

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    My mistake, the fix will be released with WP version 4.5.3.

    Plugin Author Ryan Stutzman

    (@ryan-stutzman)

    Ok, WP 4.5.3 is finally available. Once you update the plugin should work again. I just tested it and it worked for me.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Settings seem not to be saved; No changes in menu’ is closed to new replies.