• Resolved chappie

    (@chappie)


    When posts are very short – like several here – the post index page doesn’t include a link to the post page so there is no obvious way for people to leave a comment. If they click on the blog link in the sidebar, they will find the right page to post a comment – but presumably those sidebar links will scroll out of sight over time.

    Am I missing something? TIA.

Viewing 15 replies - 16 through 30 (of 39 total)
  • Thread Starter chappie

    (@chappie)

    @d4z_c0nflive testing now and it makes me smile.

    Can’t quite figure out why the span top margin grows bigger when a bubble is added but I won’t be asking for a refund.

    What about styling the “Leave comment” span without comments with a bigger top margin, and style the span with comments with a smaller margin?

    You can do this.
    In the code above,

    $bubble_comment = apply_filters( 'tc_bubble_comment', $bubble_comment );
    /* ADD THIS LINE */
     $classes = ( $bubble_comment ) ? 'has_comments' : '';
     $leave_comment_string = __('Leave a comment') . $bubble_comment;

    This way we know if the bubble comment will be added, and we’ll add a new class to the span to style it, changing the sprintf this way:

    $leave_comment_link = sprintf('<span class="chappie-comments-link comments-link %5$s"><a href="%1$s#comments" title="%2$s %3$s">%4$s</a></span>',
                                  get_permalink(),
                                  __( 'Comment(s) on' , 'customizr' ),
                                  get_the_title(),
                                  $leave_comment_string,
                                  $classes
                                  );

    What do you think about that?

    Thread Starter chappie

    (@chappie)

    What do you think about that?

    Well, d4z_c0nf, I think that’s very cool and very kind. I’m wondering whether to live with the disparity though since it also serves as an extra visual indicator that there are comments to be read.

    But out of interest, could I have achieved a matched gap between the post text and the comment span if I instead styled the post text with a bottom margin?

    You cant style the last <p> of the those post types excerpt. But isn’t supported by ie<=8
    https://www.w3schools.com/cssref/sel_last-child.asp

    Thread Starter chappie

    (@chappie)

    Thanks – I’m going to play with p:last-of-type and I’ll report back.

    Apologies in advance if I’m slow – I keep getting sidetracked by other things, acts of God, etc…and of course it doesn’t help that I really am slow!

    ?? Take your time ??

    Thread Starter chappie

    (@chappie)

    Sorry to say, I’m getting nowhere with this. Initially, for simplicity, targeting only the “aside” post format, this is the latest of several ill-judged styling attempts:

    #post .type-post .status-publish .format-aside>p:last-of-type {
    margin-bottom: 20px;
    }

    Be gentle.

    chappie sorry, I really didn’t understand what you want to achieve ??
    Can you explain it a little more to this idiot/feverish guy (me)?

    Thread Starter chappie

    (@chappie)

    ?? In an attempt to create a common gap between the last para of text and the comment span, I was trying to see whether applying some styling to the last text para would have a more uniform result than applying styling to the comment span – so that the comment span with bubble and comment span without bubble would both display in the same relative position.

    In other words, using one piece of code rather than separately styling the bubble-comment span and the no-bubble comment span.

    Ok, so I got it. The problem is, you experienced that span with bubble and span without bubble present different positions, this is because of the bubble, of course. Then how can you assign this “fixed” margin to the last p and expecting that will be the same with both, knowing that the “bubble” is the problem?
    In my opinion what you had to do was style the comment span in general with a certain margin top, and decrease that margin for the comment span with the bubble.
    That’s why I gave you the possibility to differentiate them with that additional class.

    That’s my opinion :), and I can be wrong in general, let alone when I have the fever ??

    Thread Starter chappie

    (@chappie)

    Okay, okay… But I had it in my head to fix my problem without creating an additional class – and sometimes the head doesn’t give up easily (stubborn as a mule).

    How about this: is this a robust fix?

    /*  Short post comment link span+bubble+numeral*/
    .chappie-comments-link.comments-link {
    margin-top: 5px;
    margin-bottom: -20px;
    }
    .chappie-comments-link.comments-link .fs1 {
    display: block;
    line-height: 0.7em;
    position:relative; bottom: 36px; left: 112px;
    color: #8F48E2;
    }
    .chappie-comments-link.comments-link .inner {
    position:relative; bottom: 69px; left: 112px;
    }

    So you decided to move down the bubble which if that’s okay for you, it’s okay for me.. but I don’t like it esthetically ??

    Thread Starter chappie

    (@chappie)

    No – I had already moved the bubble down but that didn’t help the spacing problem. This was the previous CSS:

    /*  Short post comment link span+bubble+numeral*/
    .chappie-comments-link.comments-link {
    
    margin-top: 0px;
    margin-bottom: -15px;
    }
    
    .chappie-comments-link.comments-link .fs1 {
    position:relative; bottom: -17px;
    color: #8F48E2;
    }
    
    .chappie-comments-link.comments-link .inner {
    position:relative; bottom: -11px;
    }
    Thread Starter chappie

    (@chappie)

    …and I’m quite happy with it aesthetically (but being a newbie, I’m not blinded by convention). I think that aligning the numeral with the text is more pleasing than shifting it up – but I accept I could be hounded out of the WP community for harbouring such heretical views.

    I would like to test with a big number, eg 258, to make sure it fits, but I’m not prepared to write 257 dummy comments…

    Well, don’t you moved the bubble down? You can say, I haven’t just moved the bubble down, <<I’ve also “removed it from the line”, with display: block and also made some magic with the number inside>>, and I’d say <<yes you’re right but>> I add <<ok now you have a great blank area below the comment span with bubble>> ??

Viewing 15 replies - 16 through 30 (of 39 total)
  • The topic ‘Short posts = no comment?’ is closed to new replies.