Shortcode filter is bad

  • Resolved alek

    (@alekart)


    8 years, 6 months ago

    Hi,
    Please make the pro/lite version shortcode filter overwritable:

    this:

    if (!Empty($attributes['id']) && Post::isGallery($attributes['id'])){
      $attributes['columns'] = Gallery_Post_Type::getMeta('columns', Null, $attributes['id']);
      $attributes['size'] = Gallery_Post_Type::getMeta('image_size', Null, $attributes['id']);
    }

    should be:

    if (!Empty($attributes['id']) && Post::isGallery($attributes['id'])){
      $attributes['columns'] = $attributes['columns'] ? $attributes['columns'] : Gallery_Post_Type::getMeta('columns', Null, $attributes['id']);
      $attributes['size'] = $attributes['size'] ? $attributes['size'] : Gallery_Post_Type::getMeta('image_size', Null, $attributes['id']);
    }

    https://www.ads-software.com/plugins/fancy-gallery/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Dennis

    (@dhoppe)

    The shortcode for embedding galleries you created within the Gallery Manager does not support the shortcode attributes “columns” and “size”. You can change these settings only in the gallery directly.

    Thread Starter alek

    (@alekart)

    If you change the code below, it will support the column and size within the shortcode.
    I need it, I changed it but I will forget about that and on next update it wont work anymore.

    I get all galeries of one category on a specific page, and setting column and size for each created gallery is just not possible because I will not manage it. There should be a general default setting or allow people use shortcode parameters.

    Your plugin is great, i’ve bought the pro version this morning but can’t believe you haven’t anticipated such usage.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Shortcode filter is bad’ is closed to new replies.