Shortcode in functions.php

Hi,

if inside the function prefix_pgmm_item you insert

echo do_shortcode( '[yasr_overall_rating]' );

does the echo works?

no, I’ve tried already. It gives me a
Parse error: syntax error, unexpected 'echo' (T_ECHO)

It shouldn’t give a parse error: can you please paste how did you put it?

like this
$MYvar = echo do_shortcode( '[yasr_overall_rating]' );

even with double quotes gives me error

Of course it return an error, you can’t put an echo inside a var.

you should simply do

echo do_shortcode( '[yasr_overall_rating]' );

so we can test if it work inside that function (that is called from add_filter)

ok, but as you can see from my first piece of code, I need all the values in the $itemContent variable, to be visible in the googlemap popup

I understood that, but can you please do as I said? So we can see if the do_shortcode works inside that function

sure, now the full code is this:

function prefix_pgmm_item($itemContent) {
	$itemContent = '';
	$itemContent .= '<strong><a href="'. get_permalink() .'" class="titolo">' . get_the_title().'</a></strong>';
	$itemContent .= wpautop(get_post_meta(get_the_ID(), '_pronamic_google_maps_address', true));
	$itemContent .= '<a href="'. get_permalink() .'" class="moreinfo">Maggiori informazioni <span>&raquo;</span></a>';
	echo do_shortcode( '[yasr_overall_rating]' );

	return $itemContent;
}
add_filter('pronamic_google_maps_mashup_item', 'prefix_pgmm_item');

no error, but no rating either

Ok, now we’re sure that we can’t use do_shortcode there.

Can you please try this code

function prefix_pgmm_item($itemContent) {
	$itemContent = '';
	$itemContent .= '<strong><a href="'. get_permalink() .'" class="titolo">' . get_the_title().'</a></strong>';
	$itemContent .= wpautop(get_post_meta(get_the_ID(), '_pronamic_google_maps_address', true));
	$itemContent .= '<a href="'. get_permalink() .'" class="moreinfo">Maggiori informazioni <span>?</span></a>';

        $MYvar = shortcode_overall_rating_callback();

        $itemContent .= $MYvar;

	return $itemContent;
}
add_filter('pronamic_google_maps_mashup_item', 'prefix_pgmm_item');

Now I get this error 4 times:

Warning: Missing argument 1 for shortcode_overall_rating_callback()

PS
grazie per la pazienza ??

Yeah you’re right, try this

function prefix_pgmm_item($itemContent) {
	$itemContent = '';
	$itemContent .= '<strong><a href="'. get_permalink() .'" class="titolo">' . get_the_title().'</a></strong>';
	$itemContent .= wpautop(get_post_meta(get_the_ID(), '_pronamic_google_maps_address', true));
	$itemContent .= '<a href="'. get_permalink() .'" class="moreinfo">Maggiori informazioni <span>?</span></a>';

        $atts = "medium";

        $MYvar = shortcode_overall_rating_callback($atts);

        $itemContent .= $MYvar;

	return $itemContent;
}
add_filter('pronamic_google_maps_mashup_item', 'prefix_pgmm_item');

no errors, but no stars yet

What if you try to insert a lower priority? (fore example)

add_filter('pronamic_google_maps_mashup_item', 'prefix_pgmm_item', 200);

Not working.

write me an email on d . curvino AT tiscali . it