Should not load admin scripts on other plugins’ pages

  • Resolved webaware

    (@webaware)


    5 years, 9 months ago

    G’day,

    This plugin is loading its scripts on other plugins’ admin pages. One serious problem this causes is Quick Edit is broken on WooCommerce.

    Please only load your scripts when your plugin is doing something. Don’t load your scripts on admin pages that are not for your plugin.

    For anyone requiring a quick fix, here’s some code that stops this plugin from breaking WooCommerce quick edit.

    /**
* stop Simple Event Calendar from breaking quick edit on WooCommerce products
*/
add_action('admin_enqueue_scripts', function($hook_suffix) {
	global $typenow;

	if ($hook_suffix === 'edit.php' && $typenow !== 'event_listing') {
		wp_dequeue_script('simple-event-planner-jQuery-ui-script');
		wp_dequeue_script('simple-event-planner-rubaxa-script');
		wp_dequeue_script('simple-event-planner-admin-scripts');
		wp_dequeue_script('simple-event-planner-jquery-datepicker');
		wp_dequeue_script('simple-event-planner-jquery-geocomplete');
		wp_dequeue_script('simple-event-planner-jquery-gmaps-latlon-picker');
	}
}, 20);

    cheers,
    Ross

    • This topic was modified 5 years, 9 months ago by webaware.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author PressTigers

    (@presstigers)

    Hi Ross,

    Thank you so much for pointing out this conflict.

    We’ll surely make our SEP scripts stick to SEP territory only to avoid from any sort of conflict.

    We are also planning to move our plugins to Github repo so PR’s would be welcomed ??

    Have a great day.

    Best Regards,

    • This reply was modified 5 years, 9 months ago by PressTigers.
    Thread Starter webaware

    (@webaware)

    G’day PressTigers,

    Awesome. A move to GitHub would help too, but last night it was all about stopping the broken ??

    cheers,
    Ross

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Should not load admin scripts on other plugins’ pages’ is closed to new replies.