Single event page: duplicate query
-
Hello!
In single tribe_events pages, Query Monitor reports that this query occurs from 50 to 60 times:
SELECT meta_value FROM wdws923_postmeta WHERE post_id = {$post->ID} AND meta_key = ‘_EventVenueID’Caller:
Tribe__Events__Integrations__WPML__Metatribe_has_venue() 4 calls Tribe__Events__JSON_LD__Event->get_data() 1 calls Tribe__Template->template_safe_include() 2 calls tribe_get_phone() 2 calls tribe_get_venue_website_link() 2 calls tribe_get_venue_link() 2 calls tribe_get_address() 10 calls tribe_get_full_address() 2 calls tribe_get_city() 8 calls tribe_get_region() 5 calls tribe_get_zip() 8 calls tribe_get_country() 8 calls tribe_get_venue() 6 calls
-
A possibile dirty solution could be cashing the main event venue id in a global variable: this way, tribe_get_event_meta is called once instead of sixty times.
src/functions/template-tags/venue.php
function tribe_get_venue_id( $postId = null ) {
$postId = Tribe__Events__Main::postIdHelper( $postId );
if ( tribe_is_venue( $postId ) ) {
return $postId;
} else {
/**
* Allow for customizing the Venue ID retrieved for this item.
*
* @since ??
* @since 4.5.12 Added docblock and venue ID to filter.
*
* @param int $venue_id The Venue ID for the specified event.
* @param int $postId The ID of the event whose venue is being looked for.
*//*
* bnkr: cash current post venue_id
*/
global $wp_query, $main_post_venue_id;
if (is_singular( Tribe__Events__Main::POSTTYPE ) && $wp_query->query_vars[‘p’] === $postId) {
if (!$main_post_venue_id) {
$main_post_venue_id = apply_filters( ‘tribe_get_venue_id’, tribe_get_event_meta( $postId, ‘_EventVenueID’, true ), $postId );
}
return $main_post_venue_id;
} else {
return apply_filters( ‘tribe_get_venue_id’, tribe_get_event_meta( $postId, ‘_EventVenueID’, true ), $postId );
}
// return apply_filters( ‘tribe_get_venue_id’, tribe_get_event_meta( $postId, ‘_EventVenueID’, true ), $postId );
}
}Without this snippet:
Memory usage:
94.225.144 byte (89,9 MB)
70,2% of 128 MB WordPress limit
Database queries
0,0265s
Total: 220
With this snippet:
Memory usage:
92.065.728 byte (87,8 MB)
68,6% of 128 MB WordPress limit
Database queries
0,0219s
Total: 161Hello,
after further tests I can say that the exact warning in english is “Update failed. Could not update the meta value of _EventVenueID in database.”.
It occurs only when the event date or time are updated, but not when updating Event content. Anyway, everything is saved as expected.
As a side note: I’m using WPML Advanced Translation Editor (default and recommended option)
https://wpml.org/documentation/translating-your-contents/translation-editor-options/
The connected Venue is translated in both the languages on the site, and so the event.
The warning appears even in events that exist in primary language only and doesn’t occurs if WPML is not active.Massimo
- The topic ‘Single event page: duplicate query’ is closed to new replies.
