Single options array and conditional queuing of JS on settings page

  • Resolved Matt Robinson

    (@mattyrob)


    9 years, 5 months ago

    @cageehv / Rolf

    Thanks for making the changes to allow this plugin to be disabled on mobile devices.

    I’ve got some further suggestions for your consideration:
    – Convert the existing options into a single array option to reduce database calls.
    – Only load javascript files on the plugin settings page in the backend, rather than on all pages.
    – Move plugin to PHP class structure to reduce chance of function and variable names clashes.
    – Move settings page code into a separate file to reduce file size load on frontend.

    I’ve actually almost complete all of this – I just need to check that the plugin remains functional. Would you like me to share the code with you somehow?

    https://www.ads-software.com/plugins/float-to-top-button/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author cageehv

    (@cageehv)

    Hey,

    Thanks for the suggestions!

    Of course I would like to see your code.

    You can send it to info #at# cagewebdev #dot# com

    Thanks!

    peace,
    Rolf

    Thread Starter Matt Robinson

    (@mattyrob)

    @cageehv / Rolf

    Great. An email is on the way to you now.

    Plugin Author cageehv

    (@cageehv)

    Hey Matt,

    I reviewed your code, fixed some bugs and just released v2.0!

    Wow, you did a lot of work! Total revamp!

    I owe you ??

    peace,
    Rolf

    Hi Matt and Rolf,

    Thank you so much for refining n developing such a nice plugin, however, after i upgrade to V2.0, my Smart Slider stop loading!! Very troubled!! I think there might be some issue or clashing with the Slider that is running on Ajax.

    The only workaround for me is to deactivate Float to Top Button and everything is back to normal! But i will loose out the conveniency for my user to navigate using Float to Top Button.

    Please help to make some patch so that those using Ajax slider and I can activate this awesome plugin again.

    Warmest regards

    Plugin Author cageehv

    (@cageehv)

    Hey abc_l,

    I will install Smart Slider and see if I can reproduce the problem.

    If you deactivate the Smart Slider does the Float to Top Button work?

    peace,
    Rolf

    Plugin Author cageehv

    (@cageehv)

    Hey abc_l,

    I’ve installed and activated Smart Slider 2 on one of my a DEV sites.
    https://www.nextendweb.com/smart-slider/
    (That’s the one you are talking about, right?)

    Slider works and Float to Top works too…

    Do you get any Javascript errors?

    peace,
    Rolf

    Hi Rolf,

    Thanks for your prompt reply!!

    If i deactivate Smart Slider 2, Float to Top still works without a problem.

    And when both are activated, my smart Slider just stubbornly not loading, and there is no error shows, the slider just don’t show up and only a white blank space.

    This only happens when i upgrade Float to top to V2.0, and during this time, there is no other upgrade was due.

    Just to confirm again,yes, that’s the slider i have installed.

    Could you please help to advise my next course of action so that I can reactivate back my Float to Top Buttons.

    Many thanks in advance!

    Hi Rolf,

    After analysing what you have explained and i went to play around the settings, I came across this option of refreshing Slider cache under Smart Slider 2 settings. So by instantaneous, i click on it and i reactivate back Float to top plugin. I was elated that my sliders are back together with Float to Top buttons.

    I am just out of words in explaining that, as i don’t even know the existence of the Slider Cache, let alone clearing it. So I really want to thank your prompt reply that really helps me in addressing this peculiar issues within a day!!!

    Sincerely appreciated!!!

    Kudos to your A1 support!!!!

    Best regards

    Plugin Author cageehv

    (@cageehv)

    Hey abc_l,

    I’m really glad you figured it out! Well done!

    Still no idea what caused the problem but I’m happy it has been resolved.

    And thanks for the kudos!

    peace,
    Rolf

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Single options array and conditional queuing of JS on settings page’ is closed to new replies.