• Resolved Optimizing Matters

    (@optimizingmatters)


    I’ve gotten reports from users that the new AMP “site scanner” functionality lists plugins of mine (WP YouTube Lyte and Autoptimize) as having compatibility issues.

    Now as both plugins explicitly skip on amp-pages (with a PR from Weston for Autoptimize), chances are these are false positives. But the “Site Scanner” results UI gives no indication whatsoever what the problem was on what page (it just tells end-users to review and suppress plugins or to browse alternative AMP compatible plugins, which is pretty harsh), so as a developers we’re completely blind.

    So my questions:
    * how can plugins that explicitly bail on AMP-pages still get listed as incompatible?
    * how can plugin/ theme developers act on this now?
    * can for a future version of AMP information be added (behind a “technical info” button or so) about what the exact problem per plugin is and and what page(s) the issue was detected?

    thanks!
    frank

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Support Milind More

    (@milindmore22)

    Hello @optimizingmatters

    Hmm that’s strange, I was not able to reproduce the issue with either WP YouTube Lyte OR Autoptimize

    Can you please share steps to reproduce the issue if any, also Please send site health info using the AMP->Support option and share your UUID, so I can share those details with devs.

    Thanks!

    Thread Starter Optimizing Matters

    (@optimizingmatters)

    Afraid I’m getting “Failed to send support request. Please try again later” when trying to send support info on my non-https localhost multisite installation where AO was listed as incompatible. Active plugins: AMP, WP YouTube Lyte & Autopitmize. Active theme: twenty-twentyone. AMP mode: standard (get the same error in transitional, no errors in reader mode). Is there any other way I can send the raw info (which I suppose is what matters most)?

    I’ll ask the user who got WP YouTube Lyte to open a topic here as well.

    Thread Starter Optimizing Matters

    (@optimizingmatters)

    OK, for Autoptimize I was able to identify & fix an issue if lazyload is active, I’ll probably release an update of AO this week (the “happy holidays”-release).

    For the user having issues with WP YouTube Lyte; that seems to be triggered by “ultimate gutenberg blocks” (based on ugb-block-frontend-js handle in the raw info).

    Remaining question (remark); it would be great if the “site scanner” could provide more technical info (hidden by default) for users to pass on to developers of conflicting plugins/ themes ??

    frank

    Plugin Support Milind More

    (@milindmore22)

    Hello @optimizingmatters

    Thank you for the additional info and good luck with the release, I did some investigation and found out that the WP YouTube Lyte plugin removes the default except filter and adds a custom filter.

    remove_filter( 'get_the_excerpt', 'wp_trim_excerpt' );
    add_filter( 'get_the_excerpt', 'lyte_trim_excerpt', 10, 2 );

    it results in pointing the WP YouTube Lyte plugin as a source of error instead of a core function.

    Hope this is helpful!

    Plugin Author Weston Ruter

    (@westonruter)

    Remaining question (remark); it would be great if the “site scanner” could provide more technical info (hidden by default) for users to pass on to developers of conflicting plugins/ themes ??

    @optimizingmatters That’s great feedback. I’ve filed a feature request for that: https://github.com/ampproject/amp-wp/issues/6807

    OK, for Autoptimize I was able to identify & fix an issue if lazyload is active, I’ll probably release an update of AO this week (the “happy holidays”-release).

    I was also able to replicate this once I activated image lazy-loading. Unfortunately, adding Autoptimize to the list of suppressed plugins in AMP does not resolve the issue. It seems because Autoptimize by default does the setup at plugins_loaded which is the same action at which plugin suppression; this needs some more investigation.

    For reference, the two validation errors coming from Autoptimize are:

    {
    	"node_name": "script",
    	"parent_name": "body",
    	"code": "DISALLOWED_TAG",
    	"type": "js_error",
    	"node_attributes": {
    		"data-noptimize": "1"
    	},
    	"text": "window.lazySizesConfig=window.lazySizesConfig||{};window.lazySizesConfig.loadMode=__INT__;",
    	"node_type": "ELEMENT",
    	"sources": [
    		{
    			"type": "plugin",
    			"name": "autoptimize",
    			"file": "classes/autoptimizeImages.php",
    			"line": 871,
    			"function": "autoptimizeImages::add_lazyload_js_footer",
    			"hook": "wp_footer",
    			"priority": 10
    		}
    	],
    	"removed": true,
    	"reviewed": false
    }

    and

    {
    	"node_name": "script",
    	"parent_name": "body",
    	"code": "DISALLOWED_TAG",
    	"type": "js_error",
    	"node_attributes": {
    		"async": "",
    		"data-noptimize": "1",
    		"src": "https://wordpressdev.lndo.site/content/plugins/autoptimize/classes/external/js/lazysizes.min.js?ao_version=2.9.4-beta-0"
    	},
    	"node_type": "ELEMENT",
    	"sources": [
    		{
    			"type": "plugin",
    			"name": "autoptimize",
    			"file": "classes/autoptimizeImages.php",
    			"line": 871,
    			"function": "autoptimizeImages::add_lazyload_js_footer",
    			"hook": "wp_footer",
    			"priority": 10
    		}
    	],
    	"removed": true,
    	"reviewed": false
    }
    Plugin Author Weston Ruter

    (@westonruter)

    Unfortunately, adding Autoptimize to the list of suppressed plugins in AMP does not resolve the issue. It seems because Autoptimize by default does the setup at plugins_loaded which is the same action at which plugin suppression; this needs some more investigation.

    I’ve filed an issue for this: https://github.com/ampproject/amp-wp/issues/6809

    Thread Starter Optimizing Matters

    (@optimizingmatters)

    thx Weston! the fix in AO (beta on github) is in commit https://github.com/futtta/autoptimize/commit/889d4342df1b84a30f0250a8fa78ac01db882c86

    Plugin Support Milind More

    (@milindmore22)

    Hope we are helpful, you can subscribe to github issue to get future updates I’ll mark this as resolved Open a new support topic if you face further issues.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Site Scanner results; allowing developers to act on issues?’ is closed to new replies.