Small code change

  • Hi Thomas,

    I’d like to request a small one-line code change in your plugin. Every time I update the plugin, I have to fix this manually:

    Line 526 of mailchim-comment-optin.php:

    Change:

    echo ‘<input type=”checkbox” name=”tgm_mc_get_subscribed” id=”tgm-mc-get-subscribed” value=”subscribe” style=”width: auto;” ‘ . $checked . ‘ />’;

    To:

    echo ‘<input type=”checkbox” name=”tgm_mc_get_subscribed” id=”tgm_mc_get_subscribed” value=”subscribe” style=”width: auto;” ‘ . $checked . ‘ />’;

    The only change is consistency with using underscores instead of dashes in the ID.

    This change breaks my custom checkboxes.

    Best,
    Paul

    https://www.ads-software.com/plugins/mailchimp-comment-optin/

Viewing 1 replies (of 1 total)

  • Can confirm. To put it in other words:

    The for attribute of the label element (tgm_mc_get_subscribed) doen’t match the id attribute of the checkbox (tgm-mc-get-subscribed).

    <input type="checkbox" name="tgm_mc_get_subscribed" id="tgm-mc-get-subscribed" value="subscribe" style="width: auto;" checked="checked">
    <label for="tgm_mc_get_subscribed"> Se inscreva em nossa newsletter</label>

    Since the id attribute seems out of consistency with the rest of the code, it should be the one to be changed.

    Thanks.

    – Edit: added code

Viewing 1 replies (of 1 total)
  • The topic ‘Small code change’ is closed to new replies.