Some bugs :)
-
Hey, I ran through the code before I installed the plugin on my site and found a few issues. I think none of this will prevent the plugin from working on my site, but you might want to fix them nonetheless ??
- First of all, in mandrill.class.php, you’re using CURL. Don’t do this. You simply cannot rely on CURL being there and WP has its own HTTP API which uses whatever transport layer is available, so you should use that.
- Then, you’re using textdomain wrong, you might want to read this post by Mark Jaquith. TL;DR: you can’t use a variable for the textdomain as it gets parsed by more than just PHP.
- The
$dir
variable on line 217 of wpmandrill.php isn’t being used. - The same is true for the
$display
variable declared on lines 1062 and 1066 - The same is true for the
$filter_used
variable declared on lines 1117, 1126 and 1133 - The same is true for the
$format_sufix
variable declared on lines 1191, 1203, 1435 and 1447
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
- The topic ‘Some bugs :)’ is closed to new replies.