Some minor markup problems
-
I experienced some minor markup problem with the Emmet theme.
There is a superfluous closing “span” in the header.php on line 181:
<button class="menu-toggle" aria-controls="main-menu" aria-expanded="false"><span class="menu-show"><?php esc_html_e('Menu', 'emmet-lite')?></span> <span class="menu-close"><?php esc_html_e('Close', 'emmet-lite')?></span> </span> </button>
The other problem is in custom-header.php:
I stumbled upon this CSS in the style section:
.site-title { color: #blank; }
Line 52 says:
* get_header_textcolor() options: Hide text (returns 'blank'), or any hex value.
Line 58 is:
$theme_header_text_color = get_header_textcolor();
And line 91 has this check:
if ($theme_header_text_color != '4f4f4f' && $theme_header_text_color != ''):
Looks like the code should check for ‘blank’ instead of an empty string ”.
Thanks for fixing!
All the best
Torsten
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
- The topic ‘Some minor markup problems’ is closed to new replies.