Some small improvements

  • Hello. I want to suggest some improvements to your plugin.
    May be you solve than it usefull.
    1. Сapability to add own class attribute. Often attribute class used for popups not only rel attribute.
    2. load_plugin_textdomain executed after include_once ‘owl_settings.php’, therefore translation do not work in owl_settings.php

    it is patch

    36d35
< load_plugin_textdomain('wp_owl', false, basename( dirname( __FILE__ ) ) . '/languages' );
55a55
>         load_plugin_textdomain('wp_owl', false, basename( dirname( __FILE__ ) ) . '/languages' );
135,142d134
<             'name' => __('Class attribute','wp_owl'),
<             'desc' => __('Used to open images in a popups that use class attribute','wp_owl'),
<             'default' => '',
<             'type' => 'text',
<             'id' => self::prefix .'cls'
<         ));
<
<         $carousel_metabox->add_field(array(
199d190
<         $cls = get_post_meta($id,self::prefix.'cls',true);
209d199
<                 $html .= (!empty($cls)) ? ' class="'.$cls.'"' : '';

    thank you for plugin

    https://www.ads-software.com/plugins/wp-owl-carousel/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Dabuuker

    (@dabuuker)

    Hey, sorry for the delayed reply. If I’d put the plugin up on Github or something would you be willing to do a pull request with the improvements? As far as I can tell WordPress’s plugin repo doesn’t really have a system for easy contributions.

    Thread Starter belogant

    (@belogant)

    Yes, of course, but it too small improvements and I think it’s easier to apply changes by yuorself.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Some small improvements’ is closed to new replies.