sp_assertionConsumerService_url using home- insted of site-url

  • Resolved puggan

    (@puggan)


    4 years, 10 months ago

    sp_assertionConsumerService_url
    defaults to: home_url( ‘/wp-login.php’ )
    should be: site_url( ‘/wp-login.php’ )

    patch:
    — a/inc/class-wp-saml-auth-settings.php 2020-01-22 00:20:19.000000000 +0100
    +++ b/inc/class-wp-saml-auth-settings.php 2020-01-22 00:20:29.000000000 +0100
    @@ -359,7 +359,7 @@ class WP_SAML_Auth_Settings {
    ‘label’ => __( ‘Assertion Consumer Service URL (Required)’, ‘wp-saml-auth’ ),
    ‘type’ => ‘url’,
    ‘description’ => __( ‘URL where the response from the IdP should be returned (usually the login URL).’, ‘wp-saml-auth’ ),
    – ‘default’ => home_url( ‘/wp-login.php’ ),
    + ‘default’ => site_url( ‘/wp-login.php’ ),
    ‘required’ => true,
    ),
    // idp section.

Viewing 1 replies (of 1 total)
  • Plugin Author Daniel Bachhuber

    (@danielbachhuber)

    Hi @puggan,

    Thanks for the report!

    The most correct function to use is wp_login_url();. It’s what’s documented in our installation instructions.

    As much as I’d like to fix the actual default value, it would be an unexpected change for everyone already using the plugin.

Viewing 1 replies (of 1 total)
  • The topic ‘sp_assertionConsumerService_url using home- insted of site-url’ is closed to new replies.