SSL Conditions Broken in Latest Update

  • Resolved wordpressorgoiwelknsdlmf

    (@wordpressorgoiwelknsdlmf)


    9 years ago

    Could not find an issue tracker on SVN or GitHub, so hopefully this is where you want bug reports.

    The latest update includes (3) references to SSL logic in
    timeline-express/classes/class.timeline-express.php

    1 of them is correct, the other two have the conditions reversed. The correct logic is…
    $http = ( is_ssl() ) ? ‘https:’ : ‘http:’;

    Note that the other two instances are written as
    $http = ( is_ssl() ) ? ‘http:’ : ‘https:’;

    Which causes mixed-content errors on SSL sites.

    https://www.ads-software.com/plugins/timeline-express/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Evan Herman

    (@eherman24)

    Hey wordpressorgoiwelknsdlmf,

    Thanks for pointing that out. Not sure how they got mixed up – but I’ll fix things up and push out an update in the next couple of hours.

    Thanks again!
    Evan

    Plugin Author Evan Herman

    (@eherman24)

    Patch is on it’s way to the repo — should be available in the next 10 minutes.

    Thanks again,
    Evan

    Thread Starter wordpressorgoiwelknsdlmf

    (@wordpressorgoiwelknsdlmf)

    Sweet response time Evan! Thanks for the quick fix, and I love the plugin :). Keep making great stuff.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘SSL Conditions Broken in Latest Update’ is closed to new replies.