Strange SEO, Yoast or die…
-
Well …i see hardcoded yoast support, or custom generated tags.
Why this plugin is closed to others SEO plugins? Why don’t use WP native functions eg. wp_get_document_title() ?Using The SEO Framework i get totally crappy title.
-
Hi @infokurs,
Does this issue also occur when activating the AMP extension, which is available for free within the Extension Manager?
I can work this out within that extension if needed.
Although, I also believe global support should be available, as you clearly mentioned.Hi @cybr,
Thx for reply. I did not know this extension before.
Almost right, except <title> tag. Title and desc on meta is correct (only on subpages).
On homepage (static page) also meta is bad.@infokurs Thanks for checking! I’ll see what I can do.
This doesn’t mean that this issue is resolved, because it will still be an issue with other and upcoming SEO plugins.
Thanks. I know, as external, dedicated patch.
Only AMP for WP direct fix can definitely solve the problem 4all.We didn’t do any hard code for Yoast SEO. We have made our plugin with WordPress Standards. We have also added Yoast SEO Integration, because of the request from the Yoast SEO User Community.
We take every issue seriously, hence I have created this as an issue in GitHub. you can see that here > https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/760
Our teammates will test and do fixes to make our plugin compatible with The SEO Framework Plugin.
@ampforwp, sorry, but no.
What WP use as meta Title? $post->post_title ??? -NO
Look: general-template.php – wp_get_document_title() – is a final output! (post SEO plugins)If i have a post eg. “XYZ”, by some SEO plugins via filter titled as “Lorem Ipsum” ….WP show XYZ as post name, but Lorem Ipsum as title.
And why i get on this plugin? Same as WordPress? – NO, but: XYZ | BlogName
>> ampforwp_add_custom_title_tag() and custom mix like:
$post->post_title . ‘ | ‘ . get_option( ‘blogname’ ) ; -for single
get_the_title( $ID ) . ‘ | ‘ . get_option(‘blogname’); -for home
-finally overriden only by Yoast if present.And why?
One simple native WP function wp_get_document_title() solve all title problems …and all SEO plugins – Yoast and others.
Do not reinvent the wheel again.Hi @ampforwp,
I understand and notice that your plugin follows WordPress’ standards.
However, I had to learn this the hard way, and I hope this helps you too:
- Use WordPress functions whenever possible (the plugin is doing this well)
- Follow step 1 to the extreme, where you can’t go any deeper.
This applies to the title. The plugin has removed legacy title calling and completely replaced it with its own version. From there it starts using WordPress functions… which is just one step too late.
As I stated in the GitHub issue, I’ll push a PR which might help ??
Cheers!@ampforwp I’ve added a PR:
https://github.com/ahmedkaludi/accelerated-mobile-pages/pull/761@infokurs feel free to test it.
Download a copy
Please note that I do not know if the branch I forked from is stable, however.As always, use at own risk ??
@cybr, almost. ??
Still homepage problem -show wrong meta, no page has set in AMP as FP, but from latest blog post ;p
@infokurs Great! Thanks ??
Is the title exactly the same as for the
og:title
meta-tag, even though it’s wrong?yes, title and og:title is the same and wrong. Also meta description is from post …og:image probably also.
And og:url direct to non-amp version.@infokurs okay awesome!
Then I just need to fix the AMP homepage detection (which is a new breed), which will be taken care of in either TSF or in the AMP extension for TSF.
Cheers! ??
Hi @infokurs,
I couldn’t reproduce the AMP home page meta issue on The SEO Framework 2.9.1.
If it’s still a concern (and you’ve updated all related plugins), do let me know and I’ll dig further (but I do need your help)!Cheers ??
- This reply was modified 7 years, 7 months ago by Sybre Waaijer.
Hi @cybr
Tested on OnePress theme.
Check this:https://embarrassed-orangutan.w2.poopy.life – HP
https://embarrassed-orangutan.w2.poopy.life/amp/ – HP AMP
https://embarrassed-orangutan.w2.poopy.life/homepage-amp/ – HP AMP (direct, set as Front Page on AMP plugin)Login: https://embarrassed-orangutan.w2.poopy.life/wp-admin/
Username: demo
Password: 70aVL4lmGa0BAfter up to 0.9.48, problem still exists.
Simplest example.
blog name: “Sandbox”
tagline: “Just another WordPress site”
homepage title: “My Home Title”
homepage description: “My Home description…”TSF settings: Title additions enabled, for homepage disabled.
ok, let’s try.
-normal: https://homely-salmon.w4.poopy.life/ -is ok, title is: “My Home Title”, desc.: “My Home description…”
-amp ver.: https://homely-salmon.w4.poopy.life/amp -omg ?? title: “Untitled | Sandbox”,
desc.: “Latest posts: Untitled on Sandbox”*problem1: before <title> tag is unwanted auto generated meta description: <meta name=”description” content=”HOME HOME HOME Lorem ipsum dolor sit amet erat. Pellentesque tempus ornare varius, quam in…”/>
*problem2: title and description do not belong to static homepage, but like blog, for latest post (there is no posts)
*problem3: for homepage amp version title and desc. format should look like definied in TSF for homepage, not for others.Next, another page https://homely-salmon.w4.poopy.life/other/ -ok, title: “Other Page Title | Sandbox”
description: “Other Page description…” -all right, according to the settings.
But on amp ver.: https://homely-salmon.w4.poopy.life/other/amp*problem1 still exists
- The topic ‘Strange SEO, Yoast or die…’ is closed to new replies.