Strings have a different text domain
-
Hello.
Strings have a different text domain (‘bdthemes-element-pack’ instead of ‘bdthemes-element-pack-lite’) and this creates problems with translate.www.ads-software.com translations (try Dutch).
Thanks.
-
Dear @itapress,
We apologize for the inconvenience. we will fix it soon.
We appreciate your kind support and patience.
Thanks in advance.Hello @tozillur23
Thank you for the reply.
I would like to point out that some strings have the wrong text domain ‘ultimate-post-kit’.
Thanks.
Dear @itapress,
Thank you for your great observation and feedback. Please allow us some time to review it. We will check and update you soon.
We appreciate your kind patience as we work to resolve the matter.
Thanks for your support
Dear @itapress,
We have fixed the issue. We kindly request you to wait for the next update version.
Thank you for sharing the issue with us and for your support.
Best regards,
Hasib Ali
Hello @hashibali
Thank you for the reply.
I tested the new version 5.6.9 and I saw that the strings that had the text domain ‘ultimate-post-kit’ have now been changed.
But unfortunately the problem remains that the plugin strings have the text domain ‘bdthemes-element-pack’ while the translations generated by translate.www.ads-software.com are associated with the text domain equal to the plugin slug, that is ‘bdthemes-element-pack-lite’ and this means that the translations are not loaded (try for example Dutch).
Thanks.
Dear @itapress,
Thank you for sharing your feedback. We will review the issue once again. Please allow us some time for this process. After reviewing the issue, we will update you soon.
Thanks
Best regards,
Hasib Ali
Dear @itapress,
It was fixed in the previous update but the syncing mistake was not released. We sincerely apologize for the mistake. We have fixed the issue on our end, and we kindly request that you wait for the next update version.
Thank you for sharing the issue with us and for your support.
Best regards,
Hasib Ali
Support Engineer at BdThemesHello @hashibali
Thank you for the reply.
Unfortunately the text domain problem is also present in the latest released version 5.6.10.
In fact, I saw that you changed the text domain in this file too, so I understood that you don’t want to conform the text domain (‘bdthemes-element-pack’) to the plugin slug (‘bdthemes-element-pack-lite’).
I then propose that you evaluate this solution that I found in this plugin, where the text domain and slug of the plugin are different, in order to use the translations generated by translate.www.ads-software.com.
Thanks.
Dear?@itapress,
Thanks for your good suggestion. There is no problem with accepting your suggested code. Would you please tell us the steps for reproducing the issue you are facing? Please record a video of the whole process and share it with us.
Thanks
Hello @hashibali
Thank you for the reply.
Unfortunately I can’t record a video because I’m in a testing environment, but I can send you screenshots which are still useful in explaining the problem.
I did the test with the Dutch language because at the moment it is the only 100% complete one on translate.www.ads-software.com and therefore I set WordPress to this language.
This is what I see before the change I proposed: https://snipboard.io/wKoJax.jpg
This is what I see after the change I proposed: https://snipboard.io/HO4jIs.jpg
Thanks.
Dear @itapress,
Thanks for sharing the screenshot with us. We are looking into it.
Hope we can provide you solution soon!
Thanks in advance.Hello @itapress ,
Thank you for your kind message. We understand your point, and you are correct. However, there is a bit of complexity on our side. We have two plugins: a lite version and a pro version. Both share more than 50% of the same features. Many users try the lite version first and then move to the pro version.
If we use ‘bdthemes-element-pack-lite’ for the lite version, it will create difficulties in our development process and also cause issues for clients who migrate from the lite to the pro version. Therefore, we use the same text domain for both versions.
In this case, please use ‘bdthemes-element-pack’ instead of ‘bdthemes-element-pack-lite’.
Hope you understand.
Thanks and regards,
Shahidul IslamFeel free to tweak it further if needed.
Hello @bdkoder
Thank you for the reply.
I understand very well the problem you have raised.
But I kindly ask you to consider including in future plugin updates a solution like the one I showed you which leaves ‘bdthemes-element-pack‘ as the text domain of the strings in the source code but allows you to load, if they are available (such as the Dutch language), the translated strings generated by translate.www.ads-software.com that the contributors of the various languages ??insert and which are associated with the plugin slug (‘bdthemes-element-pack-lite‘).
Basically it involves adding the following lines to the Free version of the plugin:
$locale = get_user_locale();
$locale = apply_filters( 'plugin_locale', $locale, 'bdthemes-element-pack' ); // phpcs:ignore
unload_textdomain( 'bdthemes-element-pack' );
load_textdomain( 'bdthemes-element-pack', WP_LANG_DIR . '/plugins/bdthemes-element-pack-lite-' . $locale . '.mo' );before the following line in the bdthemes_element_pack_load_plugin function:
load_plugin_textdomain( 'bdthemes-element-pack', false, BDTEP_PNAME . '/languages' );
I would also like to point out that the .POT file included in the plugin is named “bdthemes-element-pack-lite.pot” and I think that for consistency with the text domain it should be renamed.
I kindly ask you to try it (for example with the Dutch language) and tell me what you think.
Thanks.
- The topic ‘Strings have a different text domain’ is closed to new replies.