• Resolved Aaron Queen

    (@bompus)


    Love the theme, really makes the backend stand out.

    Plugin code is clean and well organized, almost too organized, but better that than a cluttered mess. From a developer to a developer, well done. WP should consider this theme, and adding settings to mimic it if they ever redesign the WP admin area – it actually makes it look modern and fun.

    1) Only include hideNag for non-admins, or add a setting to enable/disable it globally.

    2) Add a setting to customize the footer, instead of displaying design by Mito. I’m a developer, I get the point, but I’d rather have a setting to turn off / edit that footer text rather than commenting out the include of footer.php

    3) In postToBlog, if a user role doesn’t have access to edit_posts, they still end up seeing the “Blog” menu with your theme. This can be easily fixed by adding a condition to the code, and I’ve also included a sanity check to make sure we are operating on the correct menu item either way:

    
    if (isset($menu[5][5]) && $menu[5][5] === "menu-posts" && current_user_can("edit_posts")) {
       $menu[5][0] = 'Blog';
       $submenu['edit.php'][5][0] = 'List All Posts';
       $submenu['edit.php'][10][0] = 'Add Blog Post';
       $submenu['edit.php'][16][0] = 'Blog Tags';
    }
    

    4) Options to change the colors would be nice, or just provide a few different themes. I personally dig the colors, but others might not.

Viewing 5 replies - 1 through 5 (of 5 total)
  • +1 for options that enable you to change the colors! Are mentioned options here would also be really nice to have.

    Any word from the dev yet?

    Plugin Author GuyPrimavera

    (@guyprimavera)

    Hi Aaron and Verdi,

    These are great suggestions and I’ve added them to the list to be considered for the next release.

    This plugin was originally created for use by Design by Mito’s clients in order to give them quick access to our support site and contact details, but now that it’s becoming more popular I agree that there needs to be a setting to hide the footer link.

    The next release will be out soon, but if you have any more suggestions just let me know!

    Thanks.

    Plugin Author GuyPrimavera

    (@guyprimavera)

    Hi Aaron,

    Thanks a lot for your suggestions. I released a new version of the plugin today, and I’m pleased to say that it includes all of the features you mentioned.

    1 – You can now disable the “Hide Nag” in Settings > Aquila Settings.

    2 – There’s now an option to not show the footer credit in the settings.

    3 – Thanks for your input with the postToBlog script. I have used the edit_posts check in this version.

    4 – There’s now a “Color Scheme” tab in Aquila Settings to choose your own colours. I’ve also replaced the default colour palette in the WordPress colour picker with Google’s Material Design palette, which should give some good suggestions for colours that will work well together.

    A lot of the CSS has been re-written for this plugin version, so please let me know if you find any issues.

    Thanks!

    Thread Starter Aaron Queen

    (@bompus)

    Thanks!

    While working on a project, I came across a few more changes that I needed to make, and I believe these would benefit the community. If WP made it easy to submit a pull request, I’d do so.

    1) Can you make the return string of aquila_admin_login_logo_title() be a setting?

    2) In postToBlog.php, you commented out the submenu global. In addition, can you only update the [0] index of each submenu[‘edit.php’] item IF it already exists. I came across this when I had a role with only access to edit_posts, but in this case, your plugin always adds the “Blog Tags” menu item back in, which puts WP in a weird state and you end up with a PHP NOTICE error. Hard to explain, but if you just wrap each $submenu..[0] override in an isset, example if (isset($submenu[‘edit.php’][16])), I believe this fixed it for me. Also, what is the purpose of the echo ” at the end of aquila_admin_post_to_blog() ?

    3) In WP, if you aren’t logged in for a while, you get the interim login overlay that pops up. On this, what I was seeing in the styling was a bit off. I had added the following CSS to login.css to fix that and one other issue.

    
    body.interim-login #login {
    	/* timed out login modal */
    	top: auto;
    	-webkit-transform: none;
    	-ms-transform: none;
    	transform: none;
    }
    
    body.login #login form p {
      color:#000; /* this allows reset password hint to display, currently white on white */
    }
    

    4) I wanted the selected admin submenu item to stand out more, so I added some CSS to aquila.css – obviously, this will need to change a bit now that you have color scheme options, but I think the idea is a decent one and really helps it pop without the text looking blurred like it can when bold.

    
    #adminmenu .wp-submenu li.current a, #adminmenu a.wp-has-current-submenu:focus+.wp-submenu li.current a, #adminmenu .wp-has-current-submenu.opensub .wp-submenu li.current a {
    	color:#ffee58;
    	font-weight:normal;
    	background:#888;
    }
    
    #adminmenu .wp-submenu li.current a:hover, #adminmenu a.wp-has-current-submenu:focus+.wp-submenu li.current a:hover, #adminmenu .wp-has-current-submenu.opensub .wp-submenu li.current a:hover, #adminmenu .wp-submenu li.current a:focus, #adminmenu a.wp-has-current-submenu:focus+.wp-submenu li.current a:focus, #adminmenu .wp-has-current-submenu.opensub .wp-submenu li.current a:focus {
    	color:#ffee58;
    	font-weight:normal;
    	background:#888;
    }
    

    Hope that helps and makes sense. Any questions, just let me know. If there is some way I can just pull request or branch the plugin to provide suggested changed, I’d be open to that.

    Plugin Author GuyPrimavera

    (@guyprimavera)

    Hi Aaron,

    Thanks for pointing out these bugs and for your suggestions. I’ve added them to the list for the next update coming shortly.

    Also, well-spotted for the empty “echo”. That was going to be used for something that became unnecessary, so it’ll be removed in the next update.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Suggestions’ is closed to new replies.